Mir

Merge lp:~brandontschaefer/mir/fix-memory-leak-mutli-win-example into lp:~mir-team/mir/trunk

Proposed by Brandon Schaefer
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 976
Proposed branch: lp:~brandontschaefer/mir/fix-memory-leak-mutli-win-example
Merge into: lp:~mir-team/mir/trunk
Diff against target: 13 lines (+3/-0)
1 file modified
examples/multiwin.c (+3/-0)
To merge this branch: bzr merge lp:~brandontschaefer/mir/fix-memory-leak-mutli-win-example
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alan Griffiths Approve
Alexandros Frantzis (community) Approve
Daniel van Vugt Approve
Review via email: mp+180210@code.launchpad.net

Commit message

Release the mir surfaces when done in multiwin demo.

Description of the change

*Note I can't spell multi correctly in the branch name*

Release the 3 surfaces when done. Fixes small memory leak.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yep, this is actually a workaround for bug 1194534.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good. The CI failure is not related to the fixes...

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Looks good. The CI failure is not related to the fixes...

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/multiwin.c'
2--- examples/multiwin.c 2013-07-30 01:30:15 +0000
3+++ examples/multiwin.c 2013-08-14 18:21:38 +0000
4@@ -193,6 +193,9 @@
5 draw_window(win + w);
6 }
7
8+ mir_surface_release_sync(win[0].surface);
9+ mir_surface_release_sync(win[1].surface);
10+ mir_surface_release_sync(win[2].surface);
11 mir_connection_release(conn);
12
13 return 0;

Subscribers

People subscribed via source and target branches