Merge lp:~brandontschaefer/mir/dont-divide-by-zero-miral into lp:mir
Proposed by
Brandon Schaefer
Status: | Rejected |
---|---|
Rejected by: | Brandon Schaefer |
Proposed branch: | lp:~brandontschaefer/mir/dont-divide-by-zero-miral |
Merge into: | lp:mir |
Diff against target: |
116 lines (+66/-4) 3 files modified
src/miral/window_info.cpp (+4/-4) tests/miral/CMakeLists.txt (+1/-0) tests/miral/window_info.cpp (+61/-0) |
To merge this branch: | bzr merge lp:~brandontschaefer/mir/dont-divide-by-zero-miral |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mir CI Bot | continuous-integration | Needs Fixing | |
Alan Griffiths | Needs Information | ||
Alberto Aguirre (community) | Approve | ||
Review via email: mp+330702@code.launchpad.net |
Commit message
When a client gives a negative window width or height and leaves the default aspect ratio a divide by zero will happen when calculating width/height correction.
Description of the change
When a user gives a negative window width or height and leaves the default aspect ratio a divide by zero will happen when calculating width/height correction.
Stacktrace
http://
To post a comment you must log in.
Ok.