Merge lp:~brandontschaefer/libertine/close-pipe-fix into lp:libertine

[Brandon Schaefer]

If the socket we read from has a closed pair connection
make sure we check if the we get a error closed pipe
and clean up

[Brandon Schaefer (brandontschaefer)]

If the socket we read from has a closed pair connection
  make sure we check if the we get a error closed pipe
  and clean up

[Larry Price (larryprice)]

lgtm! thanks for the quick fix

review: Approve

[Libertine CI Bot (libertine-ci-bot)]

PASSED: Continuous integration, rev:290
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/104/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/libertine/job/build/295
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=default/244
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=default/244
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=default/244
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=vivid+overlay,testname=default/244
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=xenial+overlay,testname=default/244
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=yakkety,testname=default/244
    None: https://jenkins.canonical.com/libertine/job/lp-generic-update-mp/221/console
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-0-fetch/297
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-1-sourcepkg/release=vivid+overlay/281
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-1-sourcepkg/release=xenial+overlay/281
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-1-sourcepkg/release=yakkety/281
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=vivid+overlay/274
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=vivid+overlay/274/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/274
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/274/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=yakkety/274
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=yakkety/274/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=vivid+overlay/274
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=vivid+overlay/274/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/274
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/274/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=yakkety/274
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=yakkety/274/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/104/rebuild

review: Approve (continuous-integration)

=== modified file 'python/libertine/Libertine.py'
--- python/libertine/Libertine.py	2016-08-15 22:11:03 +0000
+++ python/libertine/Libertine.py	2016-08-19 20:51:38 +0000
@@ -624,12 +624,17 @@
 
                     totalsent = 0
                     while totalsent < len(data):
-                        sent = send_sock.send(data)
-
-                        if sent == 0:
-                            close_connections(sock)
+                        try:
+                            sent = send_sock.send(data)
+                        except BrokenPipeError as e:
+                            libertine.utils.get_logger().exception(e)
+                            self.close_connections(sock)
                             break
-                        totalsent = totalsent + sent
+                        else:
+                            if sent == 0:
+                                close_connections(sock)
+                                break
+                            totalsent = totalsent + sent
 
 
 class LibertineApplication(object):