Merge lp:~brandontschaefer/compiz/lp201681-fix-edgeflip-offset into lp:compiz/0.9.9

Proposed by Brandon Schaefer on 2012-11-29
Status: Rejected
Rejected by: Brandon Schaefer on 2012-11-30
Proposed branch: lp:~brandontschaefer/compiz/lp201681-fix-edgeflip-offset
Merge into: lp:compiz/0.9.9
Diff against target: 29 lines (+3/-2)
1 file modified
plugins/wall/src/wall.cpp (+3/-2)
To merge this branch: bzr merge lp:~brandontschaefer/compiz/lp201681-fix-edgeflip-offset
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2012-11-30
Compiz Maintainers 2012-11-29 Pending
Review via email: mp+137072@code.launchpad.net

Commit message

Fix the offset for the mouse when dragging a window to a different workspace.

Description of the change

=== Problem ===
When moving a window from any workspace to the left or up the offset was moving the mouse -10.

=== Fix ===
Put it to -1 like right, and down do.

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Sam Spilsbury (smspillaz) wrote :

Didn't Daniel just propose something like this?

Brandon Schaefer (brandontschaefer) wrote :

Yeah he did...I must have missed his MP...geez, well at lease I can confirm that was the problem :)

Unmerged revisions

3487. By Brandon Schaefer on 2012-11-29

* Fix offset when flipping edges in the wall plugin

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/wall/src/wall.cpp'
2--- plugins/wall/src/wall.cpp 2012-09-05 15:55:13 +0000
3+++ plugins/wall/src/wall.cpp 2012-11-29 22:32:25 +0000
4@@ -425,6 +425,7 @@
5 if (!checkDestination (x, y))
6 return false;
7
8+
9 if (moveWindow != moveWin)
10 {
11 CompWindow *w;
12@@ -864,7 +865,7 @@
13
14 if (dx < 0)
15 {
16- offsetX = screen->width () - 10;
17+ offsetX = screen->width () - 1;
18 warpX = pointerX + screen->width ();
19 }
20 else if (dx > 0)
21@@ -880,7 +881,7 @@
22
23 if (dy < 0)
24 {
25- offsetY = screen->height () - 10;
26+ offsetY = screen->height () - 1;
27 warpY = pointerY + screen->height ();
28 }
29 else if (dy > 0)

Subscribers

People subscribed via source and target branches