lp:~brandontschaefer/compiz/lp.906231-test

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.9 at revision 3607

PS Jenkins bot (community): Approve (continuous-integration) on 2013-02-13

Sam Spilsbury: Approve on 2013-02-13

Diff: 63 lines (+56/-0)

1 file modified

tests/system/xorg-gtest/tests/compiz_xorg_gtest_test_window_stacking.cpp (+56/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #906231: Unity rendered behind windows

High

Fix Released

Link a bug report

Related blueprints

3607. By Brandon Schaefer on 2013-02-12

* A unit test for transientFor windows and stacking order.

3606. By Sam Spilsbury on 2013-02-12

Ensure that we never get a BadWindow due to the sibling in a ConfigureWindow.

Issuing a ConfigureWindow request with a sibling parameter that refers
to a sibling that's actually destroyed server side results in a BadWindow
error, and causes what we might think is a correct ConfigureWindow request
to fail. This would cause even more problems because we had marked
the request as succeeding, and adjusted serverWindows appropriately,
which would cause further restacks to rely on the invalid internal state.

Unfortunately, this is effectively a race condition between the client and
the server. We receive our events and are racing the server to not
destroy the window internally before we get a chance to issue a
ConfigureWindow request relative to the destroyed window.

Because of that, we need to hold a server grab during the period in which
we check if the sibling window is still valid server side and when
we issue a ConfigureWindow request. If it is valid, then we can guaruntee
that the server will process the request relative to the sibling window,
and if not, we can select another sibling as appropriate.

Adjusted the API such that any function which looks for an appropriate sibling
or any function which calls XConfigureWindow with the sibling parameter
set requires a server grab to be active (by virtue of the fact that they
accept a const ServerLock &).

The only implicit contract between clients now is that the client must
obtain the sibling window either by using one of the designated functions
to do so which requires a ServerLock, or that the client holds a server lock
and while it holds the ServerLock, it calls XGetWindowAttributes or
XGetGeometry to check if the sibling window is valid.

configureXWindow was split into configureXWindow and
restackAndConfigureXWindow. The latter requires a server lock, the former
will warn about this potential race condition if you attempt to
restack a window using it.

Passing tests:

[ RUN ] CompizXorgSystemStackingTest.TestCreateRelativeToDestroyedWindowFindsAnotherAppropriatePosition
[ OK ] CompizXorgSystemStackingTest.TestCreateRelativeToDestroyedWindowFindsAnotherAppropriatePosition (55 ms)

(LP: #1088399). Fixes: https://bugs.launchpad.net/bugs/906231, https://bugs.launchpad.net/bugs/1088399.

Approved by PS Jenkins bot.

3605. By MC Return on 2013-02-12

Expose unmaximize_or_minimize_window_key instead of unmaximize_window_key
in Gnome Control Center.

(LP: #1115128). Fixes: https://bugs.launchpad.net/bugs/1115128.

Approved by Sam Spilsbury, Didier Roche.

3604. By Michail Bitzes on 2013-02-12

Plugin splash ported to OpenGL|ES.

Use GLVertexBuffer.
Enable building for GLES. Enable architectures armel and armhf.

Approved by Sam Spilsbury, MC Return.

3603. By Marco Trevisan (Treviño) on 2013-02-12

Ccp: check if an option has changed before calling the base class

Otherwise core options (that is called before) won't never be correctly updated on
setOptionForPlugin call

(LP: #1122228). Fixes: https://bugs.launchpad.net/bugs/1122228.

Approved by Sam Spilsbury.

3602. By PS Jenkins bot on 2013-02-08

Releasing 1:0.9.9~daily13.02.08-0ubuntu1, based on r3601

3601. By PS Jenkins bot on 2013-02-07

Releasing 1:0.9.9~daily13.02.07-0ubuntu1 to ubuntu.

Approved by PS Jenkins bot.

3600. By MC Return on 2013-02-07

Refactoring of thumbnail.xml.in:

Better structuring.

Converted 'Window Title Text' from subgroup to group,
thereby moving the text settings into their own tab.

Improved tooltips and titles.

Fixed indentation.

(LP: #1113459). Fixes: https://bugs.launchpad.net/bugs/1113459.

Approved by Sam Spilsbury.

3599. By MC Return on 2013-02-07

Cube Gears plugin:
Fixed the rendering of the inner cylinders by rendering them first.

(LP: #1117311). Fixes: https://bugs.launchpad.net/bugs/1117311.

Approved by Sam Spilsbury.

3598. By MC Return on 2013-02-06

Fixed cppcheck static code analysis errors/warnings/recommendations:

* Removed unused variable TfWindowList::iterator 'iter' in
  TrailfocusScreen::refillList ().

* Removed useless calculation of 'distance', because the calculated value
  is never used.

* Do not assign false to bool 'rv', because a new value is reassigned
  a few lines later, before the old one has been used.
  Declare and assign bool 'rv' in the same line instead.

* Used prefix ++ operator to increase 'rit' in the for loop, because
  pre-increment can be more efficient.

* Used prefix ++ operators to increase 'w' (x2) and 'it' in their
  respective for loops for the same reason.

* Commented out calculation of 'x2', because this value gets recalculated
  a few lines later, before having been used.

* int 'lco', 'rco', 'tco' and 'bco' got the value output assigned, but
  this value never was used, but all got new values assigned a few lines
  later.
  Declare and assign int 'lco', 'rco', 'tco' and 'bco' in the same line.

* The 'xv' and 'yv' variables are of type unsigned int, so %u is the right
  format to snprintf them, not %d.

(LP: #1114525). Fixes: https://bugs.launchpad.net/bugs/1114525.

Approved by Sam Spilsbury.