Merge lp:~brandontschaefer/compiz/lp.102246-remove-if-no-struts into lp:compiz/0.9.9
Status: | Merged |
---|---|
Approved by: | Stephen M. Webb |
Approved revision: | 3533 |
Merged at revision: | 3532 |
Proposed branch: | lp:~brandontschaefer/compiz/lp.102246-remove-if-no-struts |
Merge into: | lp:compiz/0.9.9 |
Diff against target: |
18 lines (+8/-0) 1 file modified
plugins/place/src/place.cpp (+8/-0) |
To merge this branch: | bzr merge lp:~brandontschaefer/compiz/lp.102246-remove-if-no-struts |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stephen M. Webb | Approve | ||
Sam Spilsbury | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
In the dtor for ~PlaceWindows we check if the window had struts, if so update the struts for that window. If the strut is set to NULL then remove it from the mStrutWindow list!
Description of the change
The mStrutWindows list is set before the signals are emitted that the screen has changed to unity. This means when the signals are emitted and in unity windows are destroyed they are still in the list of mStrutWindows. Another problem is the DestroyNotify event is not revived by compiz until after the monitor check is over. This means there isn't a good way to say, hey we have deleted this window, and should be removed from the list of mStrutWindows...
So in the dtor for ~PlaceWindows we update the strut for that window, if the strut is set to NULL then remove it from the mStrutWindow list!
PASSED: Continuous integration, rev:3532 jenkins. qa.ubuntu. com/job/ compiz- ci/330/ jenkins. qa.ubuntu. com/job/ compiz- ci/./build= pbuilder, distribution= quantal, flavor= amd64/330/ console
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild: jenkins. qa.ubuntu. com/job/ compiz- ci/330/ /rebuild/?
http://