Merge lp:~brandontschaefer/compiz/grid-plugin-fix into lp:compiz/0.9.9
Proposed by
Brandon Schaefer
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Daniel van Vugt | ||||
| Approved revision: | 3431 | ||||
| Merged at revision: | 3431 | ||||
| Proposed branch: | lp:~brandontschaefer/compiz/grid-plugin-fix | ||||
| Merge into: | lp:compiz/0.9.9 | ||||
| Diff against target: |
11 lines (+0/-2) 1 file modified
plugins/grid/CMakeLists.txt (+0/-2) |
||||
| To merge this branch: | bzr merge lp:~brandontschaefer/compiz/grid-plugin-fix | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| Daniel van Vugt | Approve | ||
|
Review via email:
|
|||
Commit message
Fix grid build failure (LP: #1067577)
Description of the change
Compiz fails to build the grid plugin due to 2 different standards being used. The grid plugin uses std=c++0x, while the compiz core does not. The problem being explicit instantiation of templates which breaks the ABI for any plugin that uses the std=c++0x standard.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Works for me (still). Tested gcc and clang.