lp:~brandontschaefer/compiz/fix-lp.892012

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:compiz/0.9.10

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2013-06-28

Sam Spilsbury: Needs Fixing on 2013-06-21

MC Return: Approve on 2013-06-12

Diff: 87 lines (+15/-8)

2 files modified

src/privatewindow.h (+1/-0)
src/window.cpp (+14/-8)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #892012: Window management - When a semi-maximised a window is maximised and then restored, the window position jumps and window size changes so the the window title bar is sometimes hidden underneath the top bar

High

Fix Released

Link a bug report

Related blueprints

3743. By Brandon Schaefer on 2013-06-28

* fix else if indent

3742. By Brandon Schaefer on 2013-06-28

* Work with Horz max as well now

3741. By Brandon Schaefer on 2013-06-12

* Init lastState in PrivateWindow ctor.

3740. By Brandon Schaefer on 2013-06-10

* another try...

3739. By Brandon Schaefer on 2013-06-10

* Hopefully this fixes indenting problems!

3738. By Brandon Schaefer on 2013-06-10

* Uses the last window state to see if we need to save anything when doing a full max.
* We now assume to save x,y,w,h unless we are also doing a horz max, along with a vert.

3737. By Iven Hsu on 2013-06-10

Opacify: Only dim the windows above the active window.(LP: #1189374). Fixes: https://bugs.launchpad.net/bugs/1189374.

Approved by PS Jenkins bot, Sam Spilsbury, MC Return.

3736. By Sam Spilsbury on 2013-06-08

Revert revision 3278.

Approved by PS Jenkins bot, Brandon Schaefer.

3735. By Andrea Azzarone on 2013-06-05

Extends invisible borders to the title bar too.

(LP: #717444). Fixes: https://bugs.launchpad.net/bugs/717444.

Approved by PS Jenkins bot, Christopher Townsend, Sam Spilsbury.

3734. By Sam Spilsbury on 2013-06-05

Satisfy matchers on getProperty as soon as they are set.

  The order of evaluation for matchers in Google Mock appears to be
  undefined - this means that we can't rely on the first argument being
  matched first and the second argument being matched afterwards. In turn,
  this means that any GValue may be passed to a GValueMatch which, by a
  design flaw, is unable to handle any values of a type it does not expect
  (at least not without an API change). It will silently pass the incorrect
  type to g_type_get_* which causes internal assertion failures.

  At the moment we're just interleaving the calls to getProperty and
  get_property - that way the expectations are satisfied and go away
  as soon as they're set. This in turn means that Google Mock only
  has to traverse one matcher rather than multiple matchers.

  (LP: #1187468). Fixes: https://bugs.launchpad.net/bugs/1187468.

Approved by PS Jenkins bot, Andrea Azzarone.