Merge lp:~bpierre/ubuntu-ui-toolkit/doc-fixes into lp:ubuntu-ui-toolkit/staging
- doc-fixes
- Merge into staging
Status: | Merged |
---|---|
Approved by: | Zsombor Egri |
Approved revision: | 1895 |
Merged at revision: | 1915 |
Proposed branch: | lp:~bpierre/ubuntu-ui-toolkit/doc-fixes |
Merge into: | lp:ubuntu-ui-toolkit/staging |
Diff against target: |
207 lines (+48/-37) 6 files modified
documentation/css/qtquick.css (+13/-2) src/Ubuntu/Components/Pickers/1.2/DatePicker.qml (+7/-7) src/Ubuntu/Components/Pickers/1.3/DatePicker.qml (+7/-7) src/Ubuntu/Components/plugin/uclistitem.cpp (+6/-6) src/Ubuntu/Components/plugin/uclistitemstyle.cpp (+4/-4) src/Ubuntu/Components/plugin/ucslotslayout.cpp (+11/-11) |
To merge this branch: | bzr merge lp:~bpierre/ubuntu-ui-toolkit/doc-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
ubuntu-sdk-build-bot | continuous-integration | Approve | |
Zsombor Egri | Approve | ||
Review via email: mp+289082@code.launchpad.net |
Commit message
Fix the lists style in the offline documentation
Description of the change
Fix the lists style in the offline documentation (fixes #1557472)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
FAILED: Continuous integration, rev:1895
https:/
Executed test runs:
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/
Zsombor Egri (zsombi) wrote : | # |
Thanks, things start to look much better in the docs now :)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:1895
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
Preview Diff
1 | === modified file 'documentation/css/qtquick.css' |
2 | --- documentation/css/qtquick.css 2013-07-25 13:19:45 +0000 |
3 | +++ documentation/css/qtquick.css 2016-03-15 18:27:24 +0000 |
4 | @@ -473,8 +473,19 @@ |
5 | color: red; |
6 | } |
7 | |
8 | - .qmldoc |
9 | - { |
10 | + /* The `#details ~ ul` selector is used because there is no other way to |
11 | + * target the content without overwriting the default styles of the page. |
12 | + * A better solution would be to reset the list style on the parts where |
13 | + * this style is required instead of doing it by default. */ |
14 | + .qmldoc ul, |
15 | + #details ~ ul |
16 | + { |
17 | + margin: 0 10px 10px; |
18 | + } |
19 | + .qmldoc li, |
20 | + #details ~ ul li |
21 | + { |
22 | + list-style: disc inside none; |
23 | } |
24 | |
25 | .generic .alphaChar{ |
26 | |
27 | === modified file 'src/Ubuntu/Components/Pickers/1.2/DatePicker.qml' |
28 | --- src/Ubuntu/Components/Pickers/1.2/DatePicker.qml 2015-04-30 08:32:44 +0000 |
29 | +++ src/Ubuntu/Components/Pickers/1.2/DatePicker.qml 2016-03-15 18:27:24 +0000 |
30 | @@ -98,10 +98,10 @@ |
31 | \a minimum and \a maximum properties. The interval can be altered considering |
32 | the following rules: |
33 | \list |
34 | - \li - \a minimum must be less or equal than the \l date; if the \a date |
35 | + \li \a minimum must be less or equal than the \l date; if the \a date |
36 | value is less than the given \a minimum, the date will be set to |
37 | the minimum's value |
38 | - \li - \a maximum value must be greater than the \a minimum, or invalid. |
39 | + \li \a maximum value must be greater than the \a minimum, or invalid. |
40 | When the maximum is smaller than the \l date, the \l date property |
41 | will be updated to get the maximum value. |
42 | When set to invalid date (see Date.getInvalidDate()), the upper |
43 | @@ -142,12 +142,12 @@ |
44 | The date picker consist of three pickers: year, month, and date. The exact |
45 | contents of the month and date pickers depends on the available width: |
46 | \list |
47 | - \li * full name for month, number and full day for date (“August” “28 Wednesday”) |
48 | - \li * otherwise full name for month, number and abbreviated day |
49 | + \li full name for month, number and full day for date (“August” “28 Wednesday”) |
50 | + \li otherwise full name for month, number and abbreviated day |
51 | for date (“August” “28 Wed”); |
52 | - \li * otherwise full name for month, number for date (“August” “28”); |
53 | - \li * otherwise abbreviated name for month, number for date (“Aug” “28”). |
54 | - \li * otherwise number for month, number for date (“08” “28”). |
55 | + \li otherwise full name for month, number for date (“August” “28”); |
56 | + \li otherwise abbreviated name for month, number for date (“Aug” “28”). |
57 | + \li otherwise number for month, number for date (“08” “28”). |
58 | \endlist |
59 | |
60 | \a{If the currently selected date becomes impossible due to year change (from a |
61 | |
62 | === modified file 'src/Ubuntu/Components/Pickers/1.3/DatePicker.qml' |
63 | --- src/Ubuntu/Components/Pickers/1.3/DatePicker.qml 2015-09-28 14:36:54 +0000 |
64 | +++ src/Ubuntu/Components/Pickers/1.3/DatePicker.qml 2016-03-15 18:27:24 +0000 |
65 | @@ -98,10 +98,10 @@ |
66 | \a minimum and \a maximum properties. The interval can be altered considering |
67 | the following rules: |
68 | \list |
69 | - \li - \a minimum must be less or equal than the \l date; if the \a date |
70 | + \li \a minimum must be less or equal than the \l date; if the \a date |
71 | value is less than the given \a minimum, the date will be set to |
72 | the minimum's value |
73 | - \li - \a maximum value must be greater than the \a minimum, or invalid. |
74 | + \li \a maximum value must be greater than the \a minimum, or invalid. |
75 | When the maximum is smaller than the \l date, the \l date property |
76 | will be updated to get the maximum value. |
77 | When set to invalid date (see Date.getInvalidDate()), the upper |
78 | @@ -142,12 +142,12 @@ |
79 | The date picker consist of three pickers: year, month, and date. The exact |
80 | contents of the month and date pickers depends on the available width: |
81 | \list |
82 | - \li * full name for month, number and full day for date (“August” “28 Wednesday”) |
83 | - \li * otherwise full name for month, number and abbreviated day |
84 | + \li full name for month, number and full day for date (“August” “28 Wednesday”) |
85 | + \li otherwise full name for month, number and abbreviated day |
86 | for date (“August” “28 Wed”); |
87 | - \li * otherwise full name for month, number for date (“August” “28”); |
88 | - \li * otherwise abbreviated name for month, number for date (“Aug” “28”). |
89 | - \li * otherwise number for month, number for date (“08” “28”). |
90 | + \li otherwise full name for month, number for date (“August” “28”); |
91 | + \li otherwise abbreviated name for month, number for date (“Aug” “28”). |
92 | + \li otherwise number for month, number for date (“08” “28”). |
93 | \endlist |
94 | |
95 | \a{If the currently selected date becomes impossible due to year change (from a |
96 | |
97 | === modified file 'src/Ubuntu/Components/plugin/uclistitem.cpp' |
98 | --- src/Ubuntu/Components/plugin/uclistitem.cpp 2016-02-25 19:42:11 +0000 |
99 | +++ src/Ubuntu/Components/plugin/uclistitem.cpp 2016-03-15 18:27:24 +0000 |
100 | @@ -1639,15 +1639,15 @@ |
101 | * An item is highlighted, thus highlight state toggled, when pressed and it has |
102 | * one of the following conditions fulfilled: |
103 | * \list |
104 | - * \li * \l leadingActions or \l trailingActions set, |
105 | - * \li * it has an \l action attached |
106 | - * \li * if the ListItem has an active child component, such as a \l Button, a |
107 | + * \li \l leadingActions or \l trailingActions set, |
108 | + * \li it has an \l action attached |
109 | + * \li if the ListItem has an active child component, such as a \l Button, a |
110 | * \l Switch, etc. |
111 | - * \li * in general, if an active (enabled and visible) \b MouseArea is added |
112 | + * \li in general, if an active (enabled and visible) \b MouseArea is added |
113 | * as a child component |
114 | - * \li * \l clicked signal handler is implemented or there is a slot or function |
115 | + * \li \l clicked signal handler is implemented or there is a slot or function |
116 | * connected to it |
117 | - * \li * \l pressAndHold signal handler is implemented or there is a slot or |
118 | + * \li \l pressAndHold signal handler is implemented or there is a slot or |
119 | * function connected to it. |
120 | * \endlist |
121 | * |
122 | |
123 | === modified file 'src/Ubuntu/Components/plugin/uclistitemstyle.cpp' |
124 | --- src/Ubuntu/Components/plugin/uclistitemstyle.cpp 2016-01-30 12:03:31 +0000 |
125 | +++ src/Ubuntu/Components/plugin/uclistitemstyle.cpp 2016-03-15 18:27:24 +0000 |
126 | @@ -131,11 +131,11 @@ |
127 | * |
128 | * The \c event object properties are: |
129 | * \list |
130 | - * \li * \c status - enumeration of \c {Started, Updated, Finished} values representing |
131 | + * \li \c status - enumeration of \c {Started, Updated, Finished} values representing |
132 | * the swipe event status |
133 | - * \li * \c to - (x, y) coordinates of the current mouse/touch point - read-only |
134 | - * \li * \c from - (x, y) coordinates of the previous mouse/touch point - read-only |
135 | - * \li * \c content - (x, y) updated coordinates of the \l {ListItem::contentItem} |
136 | + * \li \c to - (x, y) coordinates of the current mouse/touch point - read-only |
137 | + * \li \c from - (x, y) coordinates of the previous mouse/touch point - read-only |
138 | + * \li \c content - (x, y) updated coordinates of the \l {ListItem::contentItem} |
139 | * {ListItem.contentItem}, read-write |
140 | * \endlist |
141 | */ |
142 | |
143 | === modified file 'src/Ubuntu/Components/plugin/ucslotslayout.cpp' |
144 | --- src/Ubuntu/Components/plugin/ucslotslayout.cpp 2016-01-30 10:51:22 +0000 |
145 | +++ src/Ubuntu/Components/plugin/ucslotslayout.cpp 2016-03-15 18:27:24 +0000 |
146 | @@ -617,12 +617,12 @@ |
147 | |
148 | There are three conceptual types of slots: |
149 | \list |
150 | - \li * The \b {leading slots}, which are the ones positioned at the |
151 | + \li The \b {leading slots}, which are the ones positioned at the |
152 | beginning of the layout (i.e. they are the leftmost elements |
153 | in left-to-right locales). |
154 | - \li * The \b {trailing slots}, which are positioned after \l mainSlot, |
155 | + \li The \b {trailing slots}, which are positioned after \l mainSlot, |
156 | if any, or after the leading slots otherwise. |
157 | - \li * The \b {main slot}, which drives the positioning of |
158 | + \li The \b {main slot}, which drives the positioning of |
159 | the vertical dimension of each slot as described in section |
160 | \l {Automatic vertical positioning of slots}. This slot sits |
161 | between leading and trailing slots, and can be set using the |
162 | @@ -738,12 +738,12 @@ |
163 | platform, SlotsLayout automatically handles the vertical positioning of its |
164 | slots so that they comply with the following rules: |
165 | \list |
166 | - \li * if there's any slot which is taller or as tall as \l {mainSlot} or if |
167 | + \li if there's any slot which is taller or as tall as \l {mainSlot} or if |
168 | no \l {mainSlot} is defined, all slots will be \b {vertically centered} within the |
169 | layout (still taking \l {SlotsLayout::padding.top} and \l {SlotsLayout::padding.bottom} |
170 | into account). |
171 | \image SlotsLayout_centerVertically.png |
172 | - \li * \b{Otherwise}, all the slots (including \l {mainSlot}) will be \b {aligned to |
173 | + \li \b{Otherwise}, all the slots (including \l {mainSlot}) will be \b {aligned to |
174 | the top} of the layout with a padding of \l {SlotsLayout::padding.top} plus |
175 | the top padding of the slot, defined in its attached properties. |
176 | \image SlotsLayout_alignToTop.png |
177 | @@ -1035,10 +1035,10 @@ |
178 | The value of padding.top and padding.bottom depends on the size |
179 | of the slots which are in the layout: |
180 | \list |
181 | - \li * if, according to the rules defined in \l {Automatic vertical positioning of slots}, |
182 | + \li if, according to the rules defined in \l {Automatic vertical positioning of slots}, |
183 | the slots are supposed to align to the top of the layout, padding.top |
184 | and padding.bottom will have a value of \b{2} Grid Units. |
185 | - \li * otherwise, if according to the rules defined in \l {Automatic vertical positioning of slots} |
186 | + \li otherwise, if according to the rules defined in \l {Automatic vertical positioning of slots} |
187 | the slots are supposed to be vertically centered in the layout, \b {and} |
188 | the tallest slot (\l {mainSlot} excluded) has a height of at least 4 Grid Units, |
189 | padding.top and padding.bottom will be set to \b{1} Grid Unit. |
190 | @@ -1096,14 +1096,14 @@ |
191 | |
192 | Valid values for \l position are: |
193 | \list |
194 | - \li * SlotsLayout.First: the slot will be positioned at the |
195 | + \li SlotsLayout.First: the slot will be positioned at the |
196 | beginning of the layout |
197 | - \li * SlotsLayout.Leading: the slot will be positioned in |
198 | + \li SlotsLayout.Leading: the slot will be positioned in |
199 | the leading slots |
200 | - \li * SlotsLayout.Trailing: the slot will be positioned in |
201 | + \li SlotsLayout.Trailing: the slot will be positioned in |
202 | the trailing slots, i.e. the one towards the end of the |
203 | layout. |
204 | - \li * SlotsLayout.Last: the slot will be positioned at |
205 | + \li SlotsLayout.Last: the slot will be positioned at |
206 | the end of the layout. |
207 | \endlist |
208 |
FAILED: Continuous integration, rev:1895 /jenkins. ubuntu. com/ubuntu- sdk/job/ ubuntu- ui-toolkit- ci-armhf- stable/ 553/ /jenkins. ubuntu. com/ubuntu- sdk/job/ generic- update- mp/1984/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/ubuntu- sdk/job/ ubuntu- ui-toolkit- ci-armhf- stable/ 553/rebuild
https:/