Merge lp:~bowenfan/ols-jenkaas/ols-jenkaas into lp:~ols-jenkaas-admins/ols-jenkaas/trunk

Proposed by Bowen Fan
Status: Merged
Merged at revision: 910
Proposed branch: lp:~bowenfan/ols-jenkaas/ols-jenkaas
Merge into: lp:~ols-jenkaas-admins/ols-jenkaas/trunk
Diff against target: 12 lines (+2/-0)
1 file modified
jobs/brand-store-snap-declarations.yaml (+2/-0)
To merge this branch: bzr merge lp:~bowenfan/ols-jenkaas/ols-jenkaas
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Review via email: mp+451111@code.launchpad.net

Commit message

Override default unused cmds for retcode 0

For the brand-store-snap-declarations job, setup and landing tests
are not relevant, but because the default project template will
be used if the keys are not defined, we override them here with
commands that will always return 0 to unblock things.

To post a comment you must log in.
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

/bin/true is used across jobs to mark commands as a no-op.
I have no problem with the `echo` version but would prefer to keep things consistent across jobs, it might seem trivial but having the same string really helps on grepping the job definitions.

review: Needs Fixing
lp:~bowenfan/ols-jenkaas/ols-jenkaas updated
909. By Bowen Fan

standardize with another noop cmds using /bin/true

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/brand-store-snap-declarations.yaml'
2--- jobs/brand-store-snap-declarations.yaml 2023-09-11 12:38:42 +0000
3+++ jobs/brand-store-snap-declarations.yaml 2023-09-11 14:11:00 +0000
4@@ -3,6 +3,8 @@
5 name: 'brand-store-snap-declarations'
6 vcs: 'git'
7 trunk: 'lp:brand-store-snap-declarations'
8+ setup: '/bin/true'
9+ landing-tests: '/bin/true'
10 jobs:
11 # No landing tests to run for this purely informational repo
12 - 'trigger-{name}'

Subscribers

People subscribed via source and target branches