charm-juju-backup-all:add-some-unittests

Branch merges

Propose for merging

Merged into charm-juju-backup-all:master at revision 391048f12b58414cf9ac091ebcb1cb621970f140

Robert Gildein: Approve on 2022-08-30

Jose Guedez (community): Approve on 2022-08-30

Diff: 184 lines (+74/-16)

6 files modified

requirements-dev.txt (+1/-1)
scripts/templates/auto_backup.py (+2/-1)
src/utils.py (+10/-9)
tests/fixtures.py (+2/-0)
tests/unit/test_utils.py (+58/-4)
tox.ini (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

89a0899... by Facundo Ciccioli on 2022-08-29

Disable DEBUG logging

6bec7d0... by Facundo Ciccioli on 2022-08-29

Make linter happy

faccc55... by Facundo Ciccioli on 2022-08-29

Make linter work again

7a26576... by Facundo Ciccioli on 2022-08-29

Complete perform_backup test and create update_crontab's

0b07b23... by Facundo Ciccioli on 2022-08-29

Fix the asyncio issue

Applying Robert Gildein's fix to the asyncio issue, his words:

I could reproduce this only on 3.8.10 Python, on 3.10.4 is not there.

To fix this you need to use model = mock.MagicMock() instead of
model = mock.Mock(). Why? Not sure, libjuju required

   websockets<8.0,>=7.0; python_version < "3.9"

and if I install version 10.3 the issue disappears.

IMO it's ok to ignore that issue.

4e195d3... by Facundo Ciccioli on 2022-08-26

[WIP] Add unit test for JujuBackupAllHelper.perform_backup()

NOTE: Tests as they are are failing due to some asyncio issue. Skipping
the test_perform_backup test makes them pass.

9640489... by Sudeep Bhandari on 2022-08-18

Specified architecture: amd64

Reviewed-on: https://code.launchpad.net/~sudeephb/charm-juju-backup-all/+git/charm-juju-backup-all/+merge/428532
Reviewed-by: Eric Chen <email address hidden>

e9880d9... by Sudeep Bhandari on 2022-08-18

explicitly specified arch: amd64

87ea3b5... by Sudeep Bhandari on 2022-08-18

Added Jammy support.
The charm built on focal didn't run on jammy(and vice versa), so two different charm files are created.

Unit tests log: https://pastebin.ubuntu.com/p/tkhMKnCFZ9/
Functional tests log: https://pastebin.ubuntu.com/p/Fwf9yXBmm2/
Note that the functional tests pass for jammy and focal, but fail for bionic. This failure is because of this bug: https://bugs.launchpad.net/charm-juju-backup-all/+bug/1986687

Reviewed-on: https://code.launchpad.net/~sudeephb/charm-juju-backup-all/+git/charm-juju-backup-all/+merge/428411
Reviewed-by: Eric Chen <email address hidden>

106a80f... by Sudeep Bhandari on 2022-08-18

Rename output charmsfiles differently