Ubuntu

Merge lp:~bones/ubuntu/natty/radiotray/fix-for-722886 into lp:ubuntu/natty/radiotray

Proposed by Bones on 2011-08-02
Status: Rejected
Rejected by: Martin Pitt on 2011-10-11
Proposed branch: lp:~bones/ubuntu/natty/radiotray/fix-for-722886
Merge into: lp:ubuntu/natty/radiotray
Diff against target: 24 lines (+7/-1) 2 files modified
To merge this branch: bzr merge lp:~bones/ubuntu/natty/radiotray/fix-for-722886
Reviewer Review Type Date Requested Status
Micah Gersten Disapprove on 2011-08-16
Robert Roth (community) Approve on 2011-08-02
Ubuntu branches 2011-08-02 Pending
Review via email: mp+70107@code.launchpad.net

Description of the Change

fixed spelling mistake in description.

To post a comment you must log in.
Robert Roth (evfool) :
review: Approve
Robert Roth (evfool) wrote :

The fix looks fine, but the best would be to forward it to Debian and have it included there. Could you please forward it to them? See the instruction on the page https://wiki.ubuntu.com/Debian/Bugs in the section entitled "Using submittodebian to forward patches to Debian"

Bones (bones) wrote :

> The fix looks fine, but the best would be to forward it to Debian and have it
> included there. Could you please forward it to them? See the instruction on
> the page https://wiki.ubuntu.com/Debian/Bugs in the section entitled "Using
> submittodebian to forward patches to Debian"

All right, will do.

Micah Gersten (micahg) wrote :

Thank you for contributing to Ubuntu development. This is actually already fixed in Oneiric in radiotray 0.6.3-1. Were you intending to have this fixed in natty or just in the development release. This wouldn't qualify on its own for an SRU (https://wiki.ubuntu.com/StableReleaseUpdates), but would only qualify if something else needed updating in the stable release.

review: Needs Information
Bones (bones) wrote :

I was aware it was fixed in Oneiric, yes, it was meant for Natty.

On 2 August 2011 22:09, Micah Gersten <email address hidden> wrote:

> Review: Needs Information
> Thank you for contributing to Ubuntu development. This is actually already
> fixed in Oneiric in radiotray 0.6.3-1. Were you intending to have this
> fixed in natty or just in the development release. This wouldn't qualify on
> its own for an SRU (https://wiki.ubuntu.com/StableReleaseUpdates), but
> would only qualify if something else needed updating in the stable release.
> --
>
> https://code.launchpad.net/~bones/ubuntu/natty/radiotray/fix-for-722886/+merge/70107
> You are the owner of lp:~bones/ubuntu/natty/radiotray/fix-for-722886.
>

Micah Gersten (micahg) wrote :

Per https://lists.ubuntu.com/archives/ubuntu-devel/2011-August/033921.html, I'm rejecting this for an SRU as this package is not likely to have an SRU for anything else. I'm sorry that we weren't able to take this. Generally these types of fixes are limited to the devel release. If you have a question on what qualifies as an SRU, please feel free to ask in #ubuntu-motu or #ubuntu-devel on freenode IRC.

review: Disapprove

Unmerged revisions

5. By Bones <email address hidden> on 2011-08-02

updated descriptiob to fix spelling mistake: "itwill" to "it will"

Preview Diff

1=== modified file 'debian/changelog'
2--- debian/changelog 2010-11-19 17:50:22 +0000
3+++ debian/changelog 2011-08-02 04:59:24 +0000
4@@ -1,3 +1,9 @@
5+radiotray (0.6.1-1ubuntu1) natty; urgency=low
6+
7+ * debian/control: updated description to correct spelling mistake "itwill" to "it will" (LP: #722886)
8+
9+ -- Bones <bones@bones-VirtualBox> Tue, 02 Aug 2011 12:54:04 +1000
10+
11 radiotray (0.6.1-1) unstable; urgency=low
12
13 * New upstream release
14
15=== modified file 'debian/control'
16--- debian/control 2010-11-19 17:50:22 +0000
17+++ debian/control 2011-08-02 04:59:24 +0000
18@@ -18,5 +18,5 @@
19 Description: online radio streaming player
20 This is a simple music streaming player that lives on the system tray.
21 By clicking on the RadioTray icon, you'll be presented with a list of
22- pre-configured online radios. By selecting one of those radios, itwill
23+ pre-configured online radios. By selecting one of those radios, it will
24 start playing.

Subscribers

People subscribed via source and target branches

to all changes: