Merge lp:~boiko/texts-scope/fix_event_parsing into lp:texts-scope

Proposed by Gustavo Pichorim Boiko
Status: Rejected
Rejected by: Kyle Nitzsche
Proposed branch: lp:~boiko/texts-scope/fix_event_parsing
Merge into: lp:texts-scope
Diff against target: 12 lines (+1/-1)
1 file modified
src/query.cpp (+1/-1)
To merge this branch: bzr merge lp:~boiko/texts-scope/fix_event_parsing
Reviewer Review Type Date Requested Status
Kyle Nitzsche (community) Approve
Review via email: mp+276045@code.launchpad.net

Commit message

In the second step, process only the new events, not the whole list.

Description of the change

In the second step, process only the new events, not the whole list.

To post a comment you must log in.
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

like the calls-scope MR, this fix is needed but is not quite enough since we still get duplicated texts.

See https://code.launchpad.net/~knitzsche/texts-scope/fix_event_parsing_fixMR

I will merge that into trunk (due to time constraints) and release as 1.5 for validation.

review: Approve
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

all merged to trunk with additional noted fix and etc.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

In fact looking at the code, that while (going) thing is not needed anymore, maybe the right fix would be to remove it, but as you fixed and merged that already, let's fix that in a later version.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/query.cpp'
2--- src/query.cpp 2015-10-16 21:51:16 +0000
3+++ src/query.cpp 2015-10-28 18:51:06 +0000
4@@ -155,7 +155,7 @@
5 ev_l.append(l);
6
7 // and process them too
8- Q_FOREACH(const Event &event, ev_l) {
9+ Q_FOREACH(const Event &event, l) {
10 QDate ev_date = event.timestamp().date();
11
12 // if the date is newer than the end date, keep searching

Subscribers

People subscribed via source and target branches