Merge lp:~boiko/telephony-service/fix_dbus_tests into lp:telephony-service

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 765
Merged at revision: 765
Proposed branch: lp:~boiko/telephony-service/fix_dbus_tests
Merge into: lp:telephony-service
Diff against target: 25 lines (+3/-2)
2 files modified
handler/tests/CMakeLists.txt (+0/-1)
handler/tests/dbus-test-wrapper.sh.in (+3/-1)
To merge this branch: bzr merge lp:~boiko/telephony-service/fix_dbus_tests
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+202656@code.launchpad.net

Commit message

Make the dbus-based tests more robust.

Description of the change

Make the dbus-based tests more robust.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'handler/tests/CMakeLists.txt'
2--- handler/tests/CMakeLists.txt 2014-01-15 19:45:54 +0000
3+++ handler/tests/CMakeLists.txt 2014-01-22 12:36:36 +0000
4@@ -10,7 +10,6 @@
5 if (${USE_DBUS})
6 set(TEST_COMMAND -p ${CMAKE_CURRENT_BINARY_DIR}/${TESTNAME} -p -xunitxml -p -o -p ${CMAKE_BINARY_DIR}/test_${TESTNAME}.xml)
7 add_test(${TESTNAME} ${DBUS_RUNNER} --keep-env
8- --task dbus-monitor --ignore-return
9 --task ${CMAKE_CURRENT_BINARY_DIR}/dbus-test-wrapper.sh ${TEST_COMMAND})
10 else (${USE_DBUS})
11 add_test(${TESTNAME} ${CMAKE_CURRENT_BINARY_DIR}/${TESTNAME} -xunitxml -o ${CMAKE_BINARY_DIR}/test_${TESTNAME}.xml)
12
13=== modified file 'handler/tests/dbus-test-wrapper.sh.in'
14--- handler/tests/dbus-test-wrapper.sh.in 2014-01-15 19:45:54 +0000
15+++ handler/tests/dbus-test-wrapper.sh.in 2014-01-22 12:36:36 +0000
16@@ -16,7 +16,9 @@
17 @CMAKE_CURRENT_BINARY_DIR@/mock/telepathy-mock &
18 MOCK_PID=$!
19
20-mc-tool list
21+# wait 1 sec for the mock to start up
22+sleep 1
23+
24 mc-tool add mock/mock account0
25 mc-tool enable mock/mock/account0
26

Subscribers

People subscribed via source and target branches