Merge lp:~boiko/telephony-service/do_not_accept_outgoing_channels into lp:telephony-service
Status: | Merged |
---|---|
Approved by: | Tiago Salem Herrmann |
Approved revision: | 1111 |
Merged at revision: | 1106 |
Proposed branch: | lp:~boiko/telephony-service/do_not_accept_outgoing_channels |
Merge into: | lp:telephony-service |
Diff against target: |
200 lines (+86/-9) 5 files modified
approver/approver.cpp (+7/-4) approver/approver.h (+1/-0) tests/approver/ApproverTest.cpp (+61/-0) tests/common/mock/callchannel.cpp (+10/-2) tests/handler/HandlerTest.cpp (+7/-3) |
To merge this branch: | bzr merge lp:~boiko/telephony-service/do_not_accept_outgoing_channels |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tiago Salem Herrmann (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email:
|
Commit message
Make sure outgoing calls are not set as accepted by the approver.
Description of the change
Make sure outgoing calls are not set as accepted by the approver.
== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes
Did you successfully run all tests found in your component's Test Plan (https:/
Yes
If you changed the UI, was the change specified/approved by design?
N/A
If you changed UI labels, did you update the pot file?
N/A
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A
PASSED: Continuous integration, rev:1106 jenkins. qa.ubuntu. com/job/ telephony- service- ci/505/ jenkins. qa.ubuntu. com/job/ telephony- service- vivid-amd64- ci/177 jenkins. qa.ubuntu. com/job/ telephony- service- vivid-armhf- ci/173 jenkins. qa.ubuntu. com/job/ telephony- service- vivid-armhf- ci/173/ artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ telephony- service- vivid-i386- ci/173
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/telephony- service- ci/505/ rebuild
http://