Merge lp:~boiko/messaging-app/ship_icon into lp:messaging-app

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 262
Merged at revision: 262
Proposed branch: lp:~boiko/messaging-app/ship_icon
Merge into: lp:messaging-app
Diff against target: 15 lines (+1/-1)
1 file modified
src/messaging-app.desktop.in.in (+1/-1)
To merge this branch: bzr merge lp:~boiko/messaging-app/ship_icon
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
Review via email: mp+237152@code.launchpad.net

Commit message

Ship the messaging-app icon together with the package

Description of the change

Ship the messaging-app icon together with the package

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Not yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/messaging-app.desktop.in.in'
2--- src/messaging-app.desktop.in.in 2014-07-21 14:36:43 +0000
3+++ src/messaging-app.desktop.in.in 2014-10-03 23:06:05 +0000
4@@ -6,7 +6,7 @@
5 _Keywords=Messages;SMS;MMS;Text Messages;Text
6 Exec=messaging-app %u
7 Terminal=false
8-Icon=messaging-app
9+Icon=@CMAKE_INSTALL_PREFIX@/@MESSAGING_APP_DIR@/assets/messaging-app.png
10 MimeType=x-scheme-handler/contact;x-scheme-handler/call
11 X-Ubuntu-Touch=true
12 X-Ubuntu-Default-Department-ID=accessories
13
14=== added file 'src/qml/assets/messaging-app.png'
15Binary files src/qml/assets/messaging-app.png 1970-01-01 00:00:00 +0000 and src/qml/assets/messaging-app.png 2014-10-03 23:06:05 +0000 differ

Subscribers

People subscribed via source and target branches