Merge lp:~boiko/messaging-app/fix_autopilot into lp:messaging-app

[Gustavo Pichorim Boiko]

Wait for the messages to be marked as read before getting them in autopilot tests.

Wait for the messages to be marked as read before getting them in autopilot tests.

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/messaging-app) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed the packaging (debian), did you subscribe a core-dev to this MP?
N/A

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:81
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/184/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4052
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3637
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-trusty-amd64-ci/99
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-trusty-armhf-ci/100
        deb: http://jenkins.qa.ubuntu.com/job/messaging-app-trusty-armhf-ci/100/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-trusty-i386-ci/99
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3536
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4100
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4100/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3639
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3639/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5964
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4949

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/184/rebuild

review: Approve (continuous-integration)

[Leo Arias (elopio)]

I've finally flashed my device with Ubuntu. When I run this branch commenting the

29 time.sleep(2)

I still get the same error as before when trying to move the pointer to the message bubble:
StateNotFoundError: Object not found with name 'MessageDelegate' and properties {'id': 17}.

So loaded.wait_for(True) doesn't seem to be waiting enough for me.

review: Needs Fixing

[Gustavo Pichorim Boiko (boiko)]

> I've finally flashed my device with Ubuntu. When I run this branch commenting
> the
>
> 29 time.sleep(2)
>
> I still get the same error as before when trying to move the pointer to the
> message bubble:
> StateNotFoundError: Object not found with name 'MessageDelegate' and
> properties {'id': 17}.
>
> So loaded.wait_for(True) doesn't seem to be waiting enough for me.

After some more investigation, I found the real root cause of the problem. It happens because the messages on the thread used by the test are still unread, and then when you enter the view, the app requests history-service to mark them as read, which in turns triggers an update on the items, which makes the list view discard the previous delegates and create new ones.

I have changed the MR using the correct fix now, which is to only get the delegates after the items are already marked as read.

[Bill Filler (bfiller)]

approved
Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

Did CI run pass? If not, please explain why.
Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

[Bill Filler (bfiller)]

review: Approve

[Leo Arias (elopio)]

Thank you very much!

review: Approve (code review, ran the test)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:83
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/185/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4075/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3660
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-trusty-amd64-ci/100
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-trusty-armhf-ci/101
        deb: http://jenkins.qa.ubuntu.com/job/messaging-app-trusty-armhf-ci/101/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-trusty-i386-ci/100
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3557/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4127
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4127/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3662
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3662/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5984
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4989

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/185/rebuild

review: Needs Fixing (continuous-integration)

[lp:~boiko/messaging-app/fix_autopilot]

81. By Gustavo Pichorim Boiko on 2014-03-20

Wait for the messages to be marked as read before getting them in autopilot tests. Fixes: 1293610

=== modified file 'src/qml/MessageDelegate.qml'
--- src/qml/MessageDelegate.qml	2014-03-14 10:27:45 +0000
+++ src/qml/MessageDelegate.qml	2014-03-19 14:27:28 +0000
@@ -30,6 +30,7 @@
     property bool incoming: false
     property string textColor: incoming ? "#333333" : "#ffffff"
     property bool selectionMode: false
+    property bool unread: false
 
     anchors.left: parent ? parent.left : undefined
     anchors.right: parent ? parent.right: undefined

=== modified file 'src/qml/Messages.qml'
--- src/qml/Messages.qml	2014-03-14 10:27:45 +0000
+++ src/qml/Messages.qml	2014-03-19 14:27:28 +0000
@@ -400,6 +400,7 @@
             objectName: "message%1".arg(index)
             incoming: senderId != "self"
             selected: messageList.isSelected(messageDelegate)
+            unread: newEvent
             removable: !messages.selectionMode
             selectionMode: messages.selectionMode
             confirmRemoval: true

=== modified file 'tests/autopilot/messaging_app/emulators.py'
--- tests/autopilot/messaging_app/emulators.py	2014-03-14 10:38:24 +0000
+++ tests/autopilot/messaging_app/emulators.py	2014-03-19 14:27:28 +0000
@@ -413,11 +413,6 @@
         thread = self.select_single(
             'ThreadDelegate', objectName='thread{}'.format(participants))
         self.pointing_device.click_object(thread)
-        # XXX workaround an autopilot error we are getting with the qt5.2
-        # landing PPA. If we try to select messages without the sleep,
-        # it seems that the QML changes between autopilot selecting the
-        # object and clicking it. --elopio - 2014-03-14
-        time.sleep(2)
         return self.get_root_instance().wait_select_single(Messages)
 
 
@@ -446,7 +441,7 @@
 
     def _get_message_delegate(self, index):
         return self.wait_select_single(
-            'MessageDelegate', objectName='message{}'.format(index))
+            'MessageDelegate', objectName='message{}'.format(index), unread=False)
 
     def _long_press(self, object_):
         if model() == 'Desktop':