Merge lp:~boiko/history-service/fix_participants_on_call_ended into lp:history-service

[Gustavo Pichorim Boiko]

Prevent the history-daemon from crashing in the event of an ended call not having any remote member.

Prevent the history-daemon from crashing in the event of an ended call not having any remote member.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:195
http://jenkins.qa.ubuntu.com/job/history-service-ci/197/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/35/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/36
        deb: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/36/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/35

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/197/rebuild

review: Needs Fixing (continuous-integration)

[Sebastien Bacher (seb128)]

changing the status to see if it can make CI give it a retry

[lp:~boiko/history-service/fix_participants_on_call_ended]

196. By Gustavo Pichorim Boiko on 2015-08-18

Merge trunk.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:196
http://jenkins.qa.ubuntu.com/job/history-service-ci/207/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/45
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/46
        deb: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/46/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/45

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/207/rebuild

review: Approve (continuous-integration)

[Tiago Salem Herrmann (tiagosh)]

Looks good. thanks.

review: Approve

=== modified file 'daemon/historydaemon.cpp'
--- daemon/historydaemon.cpp	2015-04-01 20:05:39 +0000
+++ daemon/historydaemon.cpp	2015-08-18 18:14:31 +0000
@@ -334,6 +334,12 @@
         participants << contact->id();
     }
 
+    // it shouldn't happen, but in case it does, we won't crash
+    if (participants.isEmpty()) {
+        qWarning() << "Participants list was empty for call channel" << channel;
+        return;
+    }
+
     QString accountId = channel->property(History::FieldAccountId).toString();
     QVariantMap thread = threadForParticipants(accountId,
                                                History::EventTypeVoice,