Merge lp:~boiko/dialer-app/rtm-fix_live_call_controls into lp:dialer-app/rtm-14.09

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Bill Filler
Approved revision: 245
Merged at revision: 245
Proposed branch: lp:~boiko/dialer-app/rtm-fix_live_call_controls
Merge into: lp:dialer-app/rtm-14.09
Diff against target: 131 lines (+46/-47)
1 file modified
src/qml/LiveCallPage/LiveCall.qml (+46/-47)
To merge this branch: bzr merge lp:~boiko/dialer-app/rtm-fix_live_call_controls
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+244814@code.launchpad.net

Commit message

Change live call control buttons to follow design.

Description of the change

Change live call control buttons to follow design.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/LiveCallPage/LiveCall.qml'
2--- src/qml/LiveCallPage/LiveCall.qml 2014-12-12 16:12:31 +0000
3+++ src/qml/LiveCallPage/LiveCall.qml 2014-12-16 01:20:59 +0000
4@@ -55,16 +55,6 @@
5 }
6 }
7
8- property list<Action> regularActions: [
9- Action {
10- id: newCallAction
11- objectName: "newCallButton"
12- iconName: "contact"
13- text: i18n.tr("New Call")
14- onTriggered: pageStack.push(Qt.resolvedUrl("../ContactsPage/ContactsPage.qml"))
15- }
16- ]
17-
18 property Action backAction: Action {
19 id: backAction
20 objectName: "backButton"
21@@ -79,7 +69,7 @@
22 }
23
24 title: caller
25- head.actions: greeter.greeterActive ? [] : regularActions
26+ head.actions: []
27 head.backAction: backAction
28 head.sections.model: multipleAccounts ? [call.account.displayName] : undefined
29 x: header ? header.height : 0
30@@ -92,7 +82,6 @@
31 statusLabel.text = text;
32 liveCall.call = callObject;
33 liveCall.dtmfVisible = false;
34- newCallAction.visible = false;
35 closeTimer.running = true;
36 }
37
38@@ -519,41 +508,6 @@
39 width: childrenRect.width
40
41 LiveCallKeypadButton {
42- objectName: "muteButton"
43- iconSource: selected ? "microphone-mute" : "microphone"
44- enabled: !isVoicemail
45- selected: liveCall.isMuted
46- iconWidth: units.gu(3)
47- iconHeight: units.gu(3)
48- onClicked: {
49- if (call) {
50- call.muted = !call.muted
51- }
52- }
53- }
54-
55- LiveCallKeypadButton {
56- objectName: "pauseStartButton"
57- iconSource: {
58- if (callManager.backgroundCall) {
59- return "swap"
60- } else if (selected) {
61- return "media-playback-start"
62- } else {
63- return "media-playback-pause"
64- }
65- }
66- selected: liveCall.onHold
67- iconWidth: units.gu(3)
68- iconHeight: units.gu(3)
69- onClicked: {
70- if (call) {
71- call.held = !call.held
72- }
73- }
74- }
75-
76- LiveCallKeypadButton {
77 id: speakerButton
78 objectName: "speakerButton"
79 iconSource: {
80@@ -595,6 +549,51 @@
81 }
82
83 LiveCallKeypadButton {
84+ objectName: "muteButton"
85+ iconSource: selected ? "microphone-mute" : "microphone"
86+ enabled: !isVoicemail
87+ selected: liveCall.isMuted
88+ iconWidth: units.gu(3)
89+ iconHeight: units.gu(3)
90+ onClicked: {
91+ if (call) {
92+ call.muted = !call.muted
93+ }
94+ }
95+ }
96+
97+ LiveCallKeypadButton {
98+ id: newCallButton
99+ objectName: "newCallButton"
100+ iconSource: "add"
101+ iconWidth: units.gu(3)
102+ iconHeight: units.gu(3)
103+ enabled: !greeter.greeterActive
104+ onClicked: pageStack.push(Qt.resolvedUrl("../ContactsPage/ContactsPage.qml"))
105+ }
106+
107+ LiveCallKeypadButton {
108+ objectName: "pauseStartButton"
109+ iconSource: {
110+ if (callManager.backgroundCall) {
111+ return "swap"
112+ } else if (selected) {
113+ return "media-playback-start"
114+ } else {
115+ return "media-playback-pause"
116+ }
117+ }
118+ selected: liveCall.onHold
119+ iconWidth: units.gu(3)
120+ iconHeight: units.gu(3)
121+ onClicked: {
122+ if (call) {
123+ call.held = !call.held
124+ }
125+ }
126+ }
127+
128+ LiveCallKeypadButton {
129 id: dtmfButton
130 objectName: "dtmfButton"
131 iconSource: "keypad"

Subscribers

People subscribed via source and target branches