dialer-app

Merge lp:~boiko/dialer-app/rtm-active_call_hint into lp:dialer-app/rtm-14.09

  1. rtm-active_call_hint
  2. Merge into rtm-14.09
Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Bill Filler
Approved revision: 237
Merged at revision: 238
Proposed branch: lp:~boiko/dialer-app/rtm-active_call_hint
Merge into: lp:dialer-app/rtm-14.09
Diff against target: 17 lines (+2/-2)
1 file modified
src/qml/LiveCallPage/LiveCall.qml (+2/-2)
To merge this branch: bzr merge lp:~boiko/dialer-app/rtm-active_call_hint
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
Review via email: mp+243658@code.launchpad.net

Commit message

Only set the CallManager.callIndicatorVisible flag when CallManager.hasCalls.

Description of the change

Only set the CallManager.callIndicatorVisible flag when CallManager.hasCalls.

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/LiveCallPage/LiveCall.qml'
2--- src/qml/LiveCallPage/LiveCall.qml 2014-11-10 23:07:05 +0000
3+++ src/qml/LiveCallPage/LiveCall.qml 2014-12-04 13:18:29 +0000
4@@ -239,11 +239,11 @@
5 }
6
7 onActiveChanged: {
8- callManager.callIndicatorVisible = !active;
9+ callManager.callIndicatorVisible = !active && callManager.hasCalls;
10 }
11
12 Component.onCompleted: {
13- callManager.callIndicatorVisible = !active;
14+ callManager.callIndicatorVisible = !active && callManager.hasCalls;
15 }
16
17 Timer {

Subscribers

People subscribed via source and target branches