Merge lp:~boiko/dialer-app/hide_sims_emergency_mode into lp:dialer-app

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 302
Merged at revision: 315
Proposed branch: lp:~boiko/dialer-app/hide_sims_emergency_mode
Merge into: lp:dialer-app
Diff against target: 11 lines (+1/-1)
1 file modified
src/qml/DialerPage/DialerPage.qml (+1/-1)
To merge this branch: bzr merge lp:~boiko/dialer-app/hide_sims_emergency_mode
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+239104@code.launchpad.net

Commit message

Hide the SIM selector when in emergency mode.

Description of the change

Hide the SIM selector when in emergency mode.

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
Yes

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator? YES

Did CI run pass? YES

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut? YES

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/DialerPage/DialerPage.qml'
2--- src/qml/DialerPage/DialerPage.qml 2014-10-07 17:01:18 +0000
3+++ src/qml/DialerPage/DialerPage.qml 2014-10-21 16:33:53 +0000
4@@ -181,7 +181,7 @@
5
6 head.sections.model: {
7 // does not show dual sim switch if there is only one sim
8- if (!multipleAccounts) {
9+ if (!multipleAccounts || greeter.greeterActive) {
10 return undefined
11 }
12

Subscribers

People subscribed via source and target branches