Merge lp:~boiko/dialer-app/fix_livecall_hang into lp:dialer-app

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Bill Filler
Approved revision: 310
Merged at revision: 319
Proposed branch: lp:~boiko/dialer-app/fix_livecall_hang
Merge into: lp:dialer-app
Diff against target: 28 lines (+7/-0)
2 files modified
src/qml/LiveCallPage/LiveCall.qml (+4/-0)
src/qml/dialer-app.qml (+3/-0)
To merge this branch: bzr merge lp:~boiko/dialer-app/fix_livecall_hang
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+241341@code.launchpad.net

Commit message

Make sure the livecall is always in a consistent state, even after being sigstopped.

Description of the change

Make sure the livecall is always in a consistent state, even after being sigstopped.

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/LiveCallPage/LiveCall.qml'
2--- src/qml/LiveCallPage/LiveCall.qml 2014-10-07 17:01:28 +0000
3+++ src/qml/LiveCallPage/LiveCall.qml 2014-11-10 23:08:04 +0000
4@@ -101,6 +101,10 @@
5 onHasCallsChanged: {
6 if(!callManager.hasCalls) {
7 reportStatus({}, i18n.tr("No calls"));
8+ } else {
9+ closeTimer.running = false;
10+ statusLabel.text = "";
11+ liveCall.call = callManager.foregroundCall;
12 }
13 }
14 }
15
16=== modified file 'src/qml/dialer-app.qml'
17--- src/qml/dialer-app.qml 2014-10-06 19:59:17 +0000
18+++ src/qml/dialer-app.qml 2014-11-10 23:08:04 +0000
19@@ -59,6 +59,9 @@
20 onApplicationActiveChanged: {
21 if (applicationActive) {
22 telepathyHelper.registerChannelObserver()
23+ if (pageStack.currentPage.objectName == "pageLiveCall" && !callManager.hasCalls) {
24+ pageStack.pop();
25+ }
26 } else {
27 telepathyHelper.unregisterChannelObserver()
28 }

Subscribers

People subscribed via source and target branches