Merge lp:~boiko/dialer-app/fix_header_update into lp:dialer-app

[Gustavo Pichorim Boiko]

Do not pass the phone number as a parameter when pushing the live call view for an outgoing call. The correct value will be taken from the callManager.
This fixes the problem of the header not updating when switching between multiple calls.

Do not pass the phone number as a parameter when pushing the live call view for an outgoing call. The correct value will be taken from the callManager.
This fixes the problem of the header not updating when switching between multiple calls.

[Gustavo Pichorim Boiko (boiko)]

- Are there any related MPs required for this MP to build/function as expected? Please list.
no

- Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
yes

- Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
yes

- Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/dialer-app) on device or emulator?
yes

- If you changed the UI, was the change specified/approved by design?
not applicable - it is just a fix to a buggy behavior

- If you changed the packaging (debian), did you subscribe a core-dev to this MP?
not applicable - no packaging changes

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/146/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-amd64-ci/51
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-armhf-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-armhf-ci/53/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-i386-ci/51
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2720
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2486/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2381
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2722
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2722/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2487
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2487/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4923/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3452

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/146/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/147/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-amd64-ci/52
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-armhf-ci/54
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-armhf-ci/54/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-i386-ci/52
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2728
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2492/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2388
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2730
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2730/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2493
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2493/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4928/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3457

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/147/rebuild

review: Needs Fixing (continuous-integration)

[Bill Filler (bfiller)]

reviewr:
Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan(https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

Did CI run pass? If not, please explain why.
not passing, don't know why

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve

[Bill Filler (bfiller)]

- Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

- Did you successfully run all tests found in your component's Test Plan
(https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

- Did CI run pass? If not, please explain why.
yes

- Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve

[Bill Filler (bfiller)]

CI passed on device not in jenkins, don't understand why

Unmerged revisions

=== modified file 'src/qml/dialer-app.qml'
--- src/qml/dialer-app.qml	2013-10-07 21:48:12 +0000
+++ src/qml/dialer-app.qml	2014-01-29 19:32:48 +0000
@@ -72,7 +72,7 @@
             callVoicemail()
         }
         if (pageStack.depth === 1 && !callManager.hasCalls)  {
-            pageStack.push(Qt.resolvedUrl("LiveCallPage/LiveCall.qml"), {"number": number})
+            pageStack.push(Qt.resolvedUrl("LiveCallPage/LiveCall.qml"))
         }
         callManager.startCall(number);
     }