Merge lp:~boiko/dialer-app/fix_header_livecall into lp:dialer-app

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 485
Merged at revision: 485
Proposed branch: lp:~boiko/dialer-app/fix_header_livecall
Merge into: lp:dialer-app
Diff against target: 31 lines (+3/-5)
1 file modified
src/qml/LiveCallPage/LiveCall.qml (+3/-5)
To merge this branch: bzr merge lp:~boiko/dialer-app/fix_header_livecall
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Tiago Salem Herrmann (community) Approve
Review via email: mp+277372@code.launchpad.net

Commit message

Make sure we have enough space for the DTMF buttons and also keep the header text untouched.

Description of the change

Make sure we have enough space for the DTMF buttons and also keep the header text untouched.

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Looks good and works as described.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/LiveCallPage/LiveCall.qml'
2--- src/qml/LiveCallPage/LiveCall.qml 2015-11-11 11:59:43 +0000
3+++ src/qml/LiveCallPage/LiveCall.qml 2015-11-12 17:35:41 +0000
4@@ -184,7 +184,7 @@
5
6 PropertyChanges {
7 target: durationLabel
8- anchors.topMargin: units.gu(3)
9+ anchors.topMargin: units.gu(2)
10 }
11
12 PropertyChanges {
13@@ -197,10 +197,6 @@
14 opacity: 1.0
15 }
16 PropertyChanges {
17- target: liveCall
18- title: ""
19- }
20- PropertyChanges {
21 target: dtmfButton
22 iconColor: UbuntuColors.green
23 }
24@@ -509,6 +505,8 @@
25
26 visible: opacity > 0.0
27 opacity: 0.0
28+ keysWidth: units.gu(11)
29+ keysHeight: units.gu(7)
30 }
31 }
32

Subscribers

People subscribed via source and target branches