Merge lp:~boiko/dialer-app/fix_dialpad_entry_field into lp:dialer-app

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 51
Merged at revision: 50
Proposed branch: lp:~boiko/dialer-app/fix_dialpad_entry_field
Merge into: lp:dialer-app
Diff against target: 35 lines (+5/-4)
1 file modified
src/qml/DialerPage/KeypadEntry.qml (+5/-4)
To merge this branch: bzr merge lp:~boiko/dialer-app/fix_dialpad_entry_field
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tiago Salem Herrmann (community) Approve
Review via email: mp+188413@code.launchpad.net

Commit message

- Make the text center aligned in the dialer input field.
- Change the cursor delegate to use the correct color.

Description of the change

- Make the text center aligned in the dialer input field.
- Change the cursor delegate to use the correct color.

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/DialerPage/KeypadEntry.qml'
2--- src/qml/DialerPage/KeypadEntry.qml 2013-09-10 22:21:08 +0000
3+++ src/qml/DialerPage/KeypadEntry.qml 2013-09-30 18:22:04 +0000
4@@ -41,6 +41,7 @@
5 id: dots
6 clip: true
7 anchors.left: parent.left
8+ anchors.verticalCenter: parent.verticalCenter
9 text: "..."
10 visible: (input.contentWidth > (keypadEntry.width - dots.width))
11 font.pixelSize: input.font.pixelSize
12@@ -56,7 +57,7 @@
13 anchors.right: parent.right
14 anchors.rightMargin: units.gu(2)
15 anchors.verticalCenter: parent.verticalCenter
16- horizontalAlignment: TextInput.AlignRight
17+ horizontalAlignment: TextInput.AlignHCenter
18 text: ""
19 font.pixelSize: units.dp(39)
20 font.weight: Font.Light
21@@ -72,11 +73,11 @@
22 cursorDelegate: Rectangle {
23 anchors.top: parent.top
24 anchors.bottom: parent.bottom
25- width: 1
26- color: Qt.rgba(0,0,0,0.5)
27+ width: units.dp(3)
28+ color: "#DD4814"
29+ visible: input.text != ""
30 }
31
32-
33 // force cursor to be always visible
34 onCursorVisibleChanged: {
35 if (!cursorVisible)

Subscribers

People subscribed via source and target branches