Merge lp:~boiko/dialer-app/fix_autopilot2 into lp:dialer-app

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 214
Merged at revision: 214
Proposed branch: lp:~boiko/dialer-app/fix_autopilot2
Merge into: lp:dialer-app
Diff against target: 27 lines (+3/-3)
2 files modified
debian/control (+2/-1)
tests/autopilot/dialer_app/emulators.py (+1/-2)
To merge this branch: bzr merge lp:~boiko/dialer-app/fix_autopilot2
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tiago Salem Herrmann (community) Approve
Review via email: mp+229680@code.launchpad.net

Commit message

Fix getting the bottom edge tip item in the autopilot tests.

Description of the change

Fix getting the bottom edge tip item in the autopilot tests.

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/dialer-app) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~boiko/dialer-app/fix_autopilot2 updated
214. By Gustavo Pichorim Boiko

Add versioning to the ubuntu contacts plugin requirement.

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
No, but not caused by the change.

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-06-16 16:36:37 +0000
3+++ debian/control 2014-08-06 15:07:02 +0000
4@@ -26,7 +26,8 @@
5 qtdeclarative5-ubuntu-telephony0.1 | qtdeclarative5-ubuntu-telephony-plugin,
6 qtdeclarative5-ubuntu-telephony-phonenumber0.1,
7 qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
8- qtdeclarative5-ubuntu-contacts0.1, qtdeclarative5-qtcontacts-plugin,
9+ qtdeclarative5-ubuntu-contacts0.1 (>= 0.2+14.10.20140805),
10+ qtdeclarative5-qtcontacts-plugin,
11 Recommends: unity8 (>= 7.81.0~),
12 Description: Dialer application for Ubuntu
13 An application to make phone calls
14
15=== modified file 'tests/autopilot/dialer_app/emulators.py'
16--- tests/autopilot/dialer_app/emulators.py 2014-08-01 15:46:35 +0000
17+++ tests/autopilot/dialer_app/emulators.py 2014-08-06 15:07:02 +0000
18@@ -65,8 +65,7 @@
19 """Bring the bottom edge page to the screen"""
20 self.bottomEdgePageLoaded.wait_for(True)
21 try:
22- action_item = self.wait_select_single('UbuntuShape',
23- objectName='bottomEdgeTip')
24+ action_item = self.wait_select_single(objectName='bottomEdgeTip')
25 start_x = (action_item.globalRect.x +
26 (action_item.globalRect.width * 0.5))
27 # Start swiping from the top of the component because after some

Subscribers

People subscribed via source and target branches