dialer-app

Merge lp:~boiko/dialer-app/fix_ap_1.4 into lp:dialer-app

  1. fix_ap_1.4
  2. Merge into trunk
Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Francis Ginther
Approved revision: 76
Merged at revision: 76
Proposed branch: lp:~boiko/dialer-app/fix_ap_1.4
Merge into: lp:dialer-app
Diff against target: 59 lines (+5/-9)
2 files modified
tests/autopilot/dialer_app/tests/test_calls.py (+2/-8)
tests/autopilot/dialer_app/tests/test_dialer.py (+3/-1)
To merge this branch: bzr merge lp:~boiko/dialer-app/fix_ap_1.4
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Robert Bruce Park (community) Approve
Review via email: mp+194205@code.launchpad.net

Commit message

Fix autopilot tests to work with autopilot 1.4

Description of the change

Fix autopilot tests to work with autopilot 1.4

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

lgtm, just waiting for jenkins.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:76
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/106/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-amd64-ci/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-armhf-ci/11
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-armhf-ci/11/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-i386-ci/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/535
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/523/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/493
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/535
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/535/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/523
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/523/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2990/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3172/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1157
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1158

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dialer-app-ci/106/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Hmmm, that looks like a connectivity issue on the test devices... re-trying.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/dialer-app-autolanding/61/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-amd64-autolanding/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-armhf-autolanding/3
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-armhf-autolanding/3/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-i386-autolanding/3
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/537/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/525
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/495/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/537
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/537/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/525
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/525/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2992
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3174
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1161
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1162

review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Otto machine failed network this time. Checked with lab support and nothing is broken at the moment, they are digging to see if any evidence of a problem can be found. As this appears to be transient, I'll re-approve.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/dialer_app/tests/test_calls.py'
2--- tests/autopilot/dialer_app/tests/test_calls.py 2013-10-30 08:45:45 +0000
3+++ tests/autopilot/dialer_app/tests/test_calls.py 2013-11-06 18:26:19 +0000
4@@ -79,7 +79,7 @@
5 self.hangup()
6
7 # log should show call to "Unknown"
8- self.assertThat(self.history_list.count, Equals(1))
9+ self.assertThat(self.history_list.count, Eventually(Equals(1)))
10 self.assertThat(self.history_list.select_single(
11 "Label", text="Unknown"), NotEquals(None))
12
13@@ -113,8 +113,6 @@
14
15 # after remote hangs up, should switch to call log page and show call
16 # to "Unknown"
17- fn = lambda: self.app.select_single(objectName="hangupButton")
18- self.assertThat(fn, Eventually(Equals(None)))
19 self.assertThat(self.history_list.visible, Eventually(Equals(True)))
20 self.assertThat(self.history_list.count, Eventually(Equals(1)))
21 self.assertThat(self.history_list.select_single(
22@@ -168,9 +166,7 @@
23
24 Sets self.hangup_button.
25 """
26- fn = lambda: self.app.select_single(objectName="hangupButton")
27- self.assertThat(fn, Eventually(NotEquals(None)))
28- self.hangup_button = self.app.select_single(objectName="hangupButton")
29+ self.hangup_button = self.app.wait_select_single(objectName="hangupButton")
30 self.assertThat(self.hangup_button.visible, Eventually(Equals(True)))
31 self.assertThat(self.call_button.visible, Equals(False))
32
33@@ -199,8 +195,6 @@
34
35 def hangup(self):
36 self.pointing_device.click_object(self.hangup_button)
37- fn = lambda: self.app.select_single(objectName="hangupButton")
38- self.assertThat(fn, Eventually(Equals(None)))
39
40 # should switch to call log page
41 self.assertThat(self.history_list.visible, Eventually(Equals(True)))
42
43=== modified file 'tests/autopilot/dialer_app/tests/test_dialer.py'
44--- tests/autopilot/dialer_app/tests/test_dialer.py 2013-08-21 20:31:27 +0000
45+++ tests/autopilot/dialer_app/tests/test_dialer.py 2013-11-06 18:26:19 +0000
46@@ -27,10 +27,12 @@
47 keypad_entry = self.main_view.dialer_page.get_keypad_entry()
48 keypad_keys = self.main_view.dialer_page.get_keypad_keys()
49
50+ text = ""
51 for key in keypad_keys:
52 self.pointing_device.click_object(key)
53+ text += key.label
54
55- self.assertThat(keypad_entry.value, Eventually(Equals("123456789*0#")))
56+ self.assertThat(keypad_entry.value, Eventually(Equals(text)))
57
58 def test_erase_button(self):
59 keypad_entry = self.main_view.dialer_page.get_keypad_entry()

Subscribers

People subscribed via source and target branches