Merge lp:~boiko/dialer-app/do_not_call_directly into lp:dialer-app

[Gustavo Pichorim Boiko]

Do not call the phone numbers directly when clicking the items in call log.
Clicking them should only populate dialpad.

Do not call the phone numbers directly when clicking the items in call log.
Clicking them should only populate dialpad.

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
Yes

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:281
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/456/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/227
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4918
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3592
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4672
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6170
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6170/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13346
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2980
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3901
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3901/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/456/rebuild

review: Needs Fixing (continuous-integration)

[lp:~boiko/dialer-app/do_not_call_directly]

282. By Gustavo Pichorim Boiko on 2014-09-19

Do not call directly not even from the details page.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:282
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/460/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/231
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5003
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3645
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4754
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6255
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6255/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13472
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3032
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3954
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3954/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/460/rebuild

review: Needs Fixing (continuous-integration)

[Bill Filler (bfiller)]

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

Did CI run pass? If not, please explain why.
yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve

=== modified file 'src/qml/HistoryPage/HistoryDelegate.qml'
--- src/qml/HistoryPage/HistoryDelegate.qml	2014-09-12 21:06:54 +0000
+++ src/qml/HistoryPage/HistoryDelegate.qml	2014-09-19 14:29:37 +0000
@@ -50,11 +50,8 @@
             return;
         }
 
-        if (fullView && mainView.account) {
-            mainView.call(participant.phoneNumber, mainView.account.accountId);
-        } else {
-            mainView.populateDialpad(participant.phoneNumber, mainView.account ? mainView.account.accountId : "");
-        }
+        // clicking an item only populates the dialpad view, it doesn't call directly
+        mainView.populateDialpad(participant.phoneNumber, mainView.account ? mainView.account.accountId : "");
     }
 
     function selectCallType()  {

=== modified file 'src/qml/HistoryPage/HistoryDetailsPage.qml'
--- src/qml/HistoryPage/HistoryDetailsPage.qml	2014-08-20 19:58:12 +0000
+++ src/qml/HistoryPage/HistoryDetailsPage.qml	2014-09-19 14:29:37 +0000
@@ -226,11 +226,7 @@
                     anchors.centerIn: parent
                 }
                 onClicked: {
-                    if (mainView.account) {
-                        mainView.call(phoneNumber, mainView.account.accountId);
-                    } else {
-                        mainView.populateDialpad(phoneNumber, mainView.account ? mainView.account.accountId : "");
-                    }
+                    mainView.populateDialpad(phoneNumber, mainView.account ? mainView.account.accountId : "");
                 }
             }
         }