Merge lp:~boiko/dialer-app/cached_contact_info into lp:dialer-app

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 469
Merged at revision: 469
Proposed branch: lp:~boiko/dialer-app/cached_contact_info
Merge into: lp:dialer-app
Diff against target: 34 lines (+3/-3)
2 files modified
src/qml/HistoryPage/HistoryDelegate.qml (+1/-1)
src/qml/HistoryPage/HistoryPage.qml (+2/-2)
To merge this branch: bzr merge lp:~boiko/dialer-app/cached_contact_info
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+274559@code.launchpad.net

Commit message

Adapt dialer to the latest changes in history-service and telephony-service.

Description of the change

Adapt dialer to the latest changes in history-service and telephony-service.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Looks good.
thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/HistoryPage/HistoryDelegate.qml'
2--- src/qml/HistoryPage/HistoryDelegate.qml 2015-05-21 18:52:21 +0000
3+++ src/qml/HistoryPage/HistoryDelegate.qml 2015-10-15 13:58:09 +0000
4@@ -146,7 +146,7 @@
5 width: height
6 fallbackAvatarUrl: (participant.avatar && participant.avatar !== "") ? participant.avatar : "image://theme/stock_contact"
7 fallbackDisplayName: (participant.alias && participant.alias !== "") ? participant.alias : phoneNumber
8- showAvatarPicture: (fallbackAvatarUrl != "image://theme/stock_contact") || (initials.length === 0)
9+ showAvatarPicture: (fallbackAvatarUrl != "image://theme/stock_contact") || (initials.length === 0) || !interactive
10 }
11
12 Label {
13
14=== modified file 'src/qml/HistoryPage/HistoryPage.qml'
15--- src/qml/HistoryPage/HistoryPage.qml 2015-06-18 20:01:14 +0000
16+++ src/qml/HistoryPage/HistoryPage.qml 2015-10-15 13:58:09 +0000
17@@ -105,7 +105,7 @@
18 visible: false
19 property variant model: Item {
20 property string senderId: "dummy"
21- property variant participants: [ {phoneNumber:"dummy"} ]
22+ property variant participants: [ {identifier:"dummy"} ]
23 }
24 }
25
26@@ -317,7 +317,7 @@
27 historyEventModel.removeEvents(model.events)
28 }
29 }
30- property bool knownNumber: participants[0] != "x-ofono-private" && participants[0] != "x-ofono-unknown"
31+ property bool knownNumber: participants[0].identifier != "x-ofono-private" && participants[0].identifier != "x-ofono-unknown"
32 rightSideActions: [
33 Action {
34 iconName: "info"

Subscribers

People subscribed via source and target branches