Merge lp:~boiko/dialer-app/add_timeline into lp:dialer-app

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 44
Merged at revision: 45
Proposed branch: lp:~boiko/dialer-app/add_timeline
Merge into: lp:dialer-app
Diff against target: 147 lines (+76/-5)
4 files modified
src/qml/HistoryPage/HistoryDelegate.qml (+13/-5)
src/qml/HistoryPage/HistoryPage.qml (+4/-0)
src/qml/HistoryPage/Timeline.qml (+54/-0)
src/qml/assets/timeline_vertical_line@27.sci (+5/-0)
To merge this branch: bzr merge lp:~boiko/dialer-app/add_timeline
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+187323@code.launchpad.net

Commit message

Add a timeline indicator in the call log view.

Description of the change

Add a timeline indicator in the call log view.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/HistoryPage/HistoryDelegate.qml'
2--- src/qml/HistoryPage/HistoryDelegate.qml 2013-09-09 19:08:23 +0000
3+++ src/qml/HistoryPage/HistoryDelegate.qml 2013-09-24 19:11:36 +0000
4@@ -31,6 +31,7 @@
5 property bool incoming: model.senderId != "self"
6 property bool unknownContact: contactWatcher.contactId == ""
7 property string phoneNumberSubTypeLabel: ""
8+ property alias isFirst: timeline.isFirst
9
10 height: units.gu(9)
11 removable: true
12@@ -123,8 +124,6 @@
13 anchors.right: phoneIcon.left
14 anchors.top: parent.top
15 anchors.bottom: parent.bottom
16- anchors.topMargin: units.gu(1)
17- anchors.bottomMargin: units.gu(1)
18
19 UbuntuShape {
20 id: time
21@@ -144,10 +143,19 @@
22 }
23 }
24
25+ Timeline {
26+ id: timeline
27+ anchors.top: parent.top
28+ anchors.bottom: parent.bottom
29+ anchors.left: time.right
30+ anchors.leftMargin: units.gu(0.5)
31+ }
32+
33 UbuntuShape {
34 id: avatar
35- anchors.left: time.right
36- anchors.leftMargin: units.gu(3.5)
37+ anchors.left: timeline.right
38+ anchors.leftMargin: units.gu(1)
39+ anchors.verticalCenter: parent.verticalCenter
40 height: units.gu(7)
41 width: height
42 image: Image {
43@@ -180,7 +188,7 @@
44
45 Column {
46 width: childrenRect.width
47- anchors.top: parent.top
48+ anchors.top: avatar.top
49 anchors.bottom: parent.bottom
50 anchors.left: avatar.right
51 anchors.leftMargin: units.gu(2)
52
53=== modified file 'src/qml/HistoryPage/HistoryPage.qml'
54--- src/qml/HistoryPage/HistoryPage.qml 2013-08-29 16:51:59 +0000
55+++ src/qml/HistoryPage/HistoryPage.qml 2013-09-24 19:11:36 +0000
56@@ -62,6 +62,9 @@
57 currentIndex: -1
58 section.property: "date"
59 section.delegate: Item {
60+ ListItem.ThinDivider {
61+ anchors.top: parent.top
62+ }
63 anchors.left: parent.left
64 anchors.right: parent.right
65 height: units.gu(5)
66@@ -90,6 +93,7 @@
67 anchors.right: parent.right
68 anchors.top: parent.top
69 onClicked: mainView.call(model.participants[0])
70+ isFirst: model.index == 0
71 }
72
73 asynchronous: true
74
75=== added file 'src/qml/HistoryPage/Timeline.qml'
76--- src/qml/HistoryPage/Timeline.qml 1970-01-01 00:00:00 +0000
77+++ src/qml/HistoryPage/Timeline.qml 2013-09-24 19:11:36 +0000
78@@ -0,0 +1,54 @@
79+/*
80+ * Copyright 2012-2013 Canonical Ltd.
81+ *
82+ * This file is part of dialer-app.
83+ *
84+ * dialer-app is free software; you can redistribute it and/or modify
85+ * it under the terms of the GNU General Public License as published by
86+ * the Free Software Foundation; version 3.
87+ *
88+ * dialer-app is distributed in the hope that it will be useful,
89+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
90+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
91+ * GNU General Public License for more details.
92+ *
93+ * You should have received a copy of the GNU General Public License
94+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
95+ */
96+
97+import QtQuick 2.0
98+import Ubuntu.Components 0.1
99+
100+Item {
101+ property bool isFirst: false
102+
103+ width: units.gu(2)
104+ height: units.gu(10)
105+
106+ BorderImage {
107+ id: topLine
108+ visible: !isFirst
109+ anchors.top: parent.top
110+ anchors.bottom: circle.top
111+ anchors.verticalCenter: circle.verticalCenter
112+ source: "../assets/timeline_vertical_line.sci"
113+ smooth: true
114+ }
115+
116+ Image {
117+ id: circle
118+ anchors.verticalCenter: parent.verticalCenter
119+ anchors.horizontalCenter: parent.horizontalCenter
120+ source: "../assets/timeline_circle.png"
121+ smooth: true
122+ }
123+
124+ BorderImage {
125+ id: bottomLine
126+ anchors.top: circle.bottom
127+ anchors.bottom: parent.bottom
128+ anchors.verticalCenter: circle.verticalCenter
129+ source: "../assets/timeline_vertical_line.sci"
130+ smooth: true
131+ }
132+}
133
134=== added file 'src/qml/assets/timeline_circle@27.png'
135Binary files src/qml/assets/timeline_circle@27.png 1970-01-01 00:00:00 +0000 and src/qml/assets/timeline_circle@27.png 2013-09-24 19:11:36 +0000 differ
136=== added file 'src/qml/assets/timeline_vertical_line@27.png'
137Binary files src/qml/assets/timeline_vertical_line@27.png 1970-01-01 00:00:00 +0000 and src/qml/assets/timeline_vertical_line@27.png 2013-09-24 19:11:36 +0000 differ
138=== added file 'src/qml/assets/timeline_vertical_line@27.sci'
139--- src/qml/assets/timeline_vertical_line@27.sci 1970-01-01 00:00:00 +0000
140+++ src/qml/assets/timeline_vertical_line@27.sci 2013-09-24 19:11:36 +0000
141@@ -0,0 +1,5 @@
142+border.left: 20
143+border.top: 0
144+border.bottom: 0
145+border.right: 20
146+source: timeline_vertical_line@27.png
147\ No newline at end of file

Subscribers

People subscribed via source and target branches