Merge ~boginw/langpack-o-matic:master into langpack-o-matic:master

[Bogi]

Added basic readme and made scripts compatible with Python 3

As Python 2 was sunset on the 1st of January 2020 if the project should stay useful it must be compatible with Python 3.

This merge proposal mainly focuses on the `import` script. Most of the code is already compatible with Python 3, but there are a few places where `urlopen` is used from `urllib2`, instead of `urllib.request`. This merge proposal proposes using a fallback import like is already used in `lib/static_translations.py`. Along with strings being used in contexts where binary strings are expected. In these places, `.encode()` is introduced.

Finally, this merge proposal introduces a basic README.md, including the prerequisites which I had to follow in order to get the import script to work.

[Sebastien Bacher (seb128)]

Thanks!

review: Approve

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..3ce1e87
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,5 @@
+updated-packages
+bin/msgequal
+__pycache__/
+*.py[cod]
+out
diff --git a/README.md b/README.md
new file mode 100644
index 0000000..5e5840e
--- /dev/null
+++ b/README.md
@@ -0,0 +1,14 @@
+# Langpack-o-matic
+
+Prerequisites:
+* libgettextpo-dev
+* Python 3
+* gettext
+* debhelper
+
+Before running, `msgequal` will have to be compiled:
+
+```bash
+cd bin
+make
+```
diff --git a/import b/import
index 48477ff..310ed7c 100755
--- a/import
+++ b/import
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 # this is part of langpack-o-matic, by Martin Pitt <[e-mail]>
 #
@@ -21,7 +21,11 @@ import tempfile
 import shutil
 import optparse
 import logging
-import urllib
+try:
+    from urllib.request import urlopen
+except ImportError:
+    # python 2 fallback
+    from urllib2 import urlopen
 import json
 
 DEFAULT_MIRROR = 'http://archive.ubuntu.com/ubuntu'
@@ -160,7 +164,7 @@ def write_po(locale, domain, pkgdir, contents):
         # used msgequal for English.
         msgequal = subprocess.Popen(['bin/msgequal', '-', dest],
                                     stdin=subprocess.PIPE)
-        msgequal.communicate(contents)
+        msgequal.communicate(contents.encode())
         assert msgequal.returncode == 0
     else:
         f = open(dest, 'w')
@@ -192,7 +196,7 @@ def normalize_po(contents):
                               stdin=subprocess.PIPE, stdout=subprocess.PIPE,
                               stderr=subprocess.PIPE)
     try:
-        (out, err) = msgfmt.communicate(contents)
+        (out, err) = msgfmt.communicate(contents.encode())
     except OSError as e:
         logging.warning('msgfmt failed with OSError: %s, not normalizing', str(e))
         return (contents, 0)
@@ -210,9 +214,9 @@ def normalize_po(contents):
     (out, err) = msgunfmt.communicate(out)
 
     # remove X-Launchpad-Export-Date:
-    export_date = out.find('\n"X-Launchpad-Export-Date: ')
+    export_date = out.find(b'\n"X-Launchpad-Export-Date: ')
     if export_date >= 0:
-        out = out[:export_date] + out[out.index('\n', export_date + 1):]
+        out = out[:export_date] + out[out.index(b'\n', export_date + 1):]
     return (out, num_strings)
 
 
@@ -402,7 +406,7 @@ def get_translatable_counts(release):
         os.environ.get('TRANSLATION_STATS_URL', 'http://people.canonical.com/~people-l10n/data/ubuntu-l10n/'),
         '%s_%s_potemplate-stats.json' % (distribution, release.split('-')[0]))
 
-    f = urllib.urlopen(url)
+    f = urlopen(url)
     data = json.load(f)
     f.close()
 
diff --git a/lib/makepkg.py b/lib/makepkg.py
index e792f68..b8b1147 100644
--- a/lib/makepkg.py
+++ b/lib/makepkg.py
@@ -70,7 +70,7 @@ def make_pkg(skeleton, path, lpmacros, extra_tar=None):
             tardata = gzip.open(extra_tar).read()
         else:
             tardata = fcontents(extra_tar)
-        f = open(target, 'w')
+        f = open(target, 'wb')
         f.write(tardata)
         f.close()
 
diff --git a/lib/static_translations.py b/lib/static_translations.py
index 5237a7b..3f104f2 100644
--- a/lib/static_translations.py
+++ b/lib/static_translations.py
@@ -171,6 +171,9 @@ def _get_release_interval(distro, min, max):
     max_num = _file_map('maps/releaseversions-' + distro, max.split('-')[0])
     result = []
 
+    def cmp(a, b):
+        return (a > b) - (a < b) 
+
     def _cmp(v1, v2):
         '''Compare two Ubuntu release numbers'''