Merge lp:~bobo-324/reminders-app/fix-1279783 into lp:reminders-app

Proposed by Boren Zhang
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 63
Merged at revision: 90
Proposed branch: lp:~bobo-324/reminders-app/fix-1279783
Merge into: lp:reminders-app
Diff against target: 23 lines (+6/-1)
1 file modified
src/app/qml/ui/NotebooksPage.qml (+6/-1)
To merge this branch: bzr merge lp:~bobo-324/reminders-app/fix-1279783
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Riccardo Padovani Approve
Review via email: mp+206341@code.launchpad.net

Commit message

Fixed 1279783

Description of the change

add
        Item {
            id: keyboardRect
            anchors { left: parent.left; right: parent.right }
            height: Qt.inputMethod.keyboardRectangle.height
        }
to the NotebooksPage.qml. track the height of the keyboard to show save buttons when edit.
Copied from EditNotePage.qml

To post a comment you must log in.
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Tested on mako, works as expected.

Sorry for the delay!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/NotebooksPage.qml'
2--- src/app/qml/ui/NotebooksPage.qml 2014-02-12 15:44:02 +0000
3+++ src/app/qml/ui/NotebooksPage.qml 2014-02-14 06:36:31 +0000
4@@ -105,7 +105,7 @@
5 ListView {
6 model: notebooks
7 anchors { left: parent.left; right: parent.right }
8- height: parent.height - y - buttonRow.height
9+ height: parent.height - y - buttonRow.height - keyboardRect.height
10
11 delegate: NotebooksDelegate {
12 name: model.name
13@@ -149,5 +149,10 @@
14 }
15 }
16 }
17+ Item {
18+ id: keyboardRect
19+ anchors { left: parent.left; right: parent.right }
20+ height: Qt.inputMethod.keyboardRectangle.height
21+ }
22 }
23 }

Subscribers

People subscribed via source and target branches