Merge lp:~bmastell/ubuntu-accomplishments-daemon/fix-for-1031913 into lp:ubuntu-accomplishments-daemon

Proposed by Brian Mastell
Status: Merged
Merged at revision: 124
Proposed branch: lp:~bmastell/ubuntu-accomplishments-daemon/fix-for-1031913
Merge into: lp:ubuntu-accomplishments-daemon
Diff against target: 15 lines (+2/-2)
1 file modified
accomplishments/daemon/api.py (+2/-2)
To merge this branch: bzr merge lp:~bmastell/ubuntu-accomplishments-daemon/fix-for-1031913
Reviewer Review Type Date Requested Status
Ubuntu Accomplishments Daemon Developers Pending
Review via email: mp+118225@code.launchpad.net

Description of the change

Swapped the return values.
Now, if the ubuntuone config file is found and that file has a section called "notifications" and it has a key "show_all_notifications", get_block_ubuntuone_notification_bubbles() returns the opposite of the value. If get_block_ubuntuone_notification_bubbles() is unable to get the value, it returns True.

To post a comment you must log in.
Revision history for this message
Jono Bacon (jonobacon) wrote :

Thanks, Brian, for the contribution. This looks great - merging in!

Welcome to the community and let us know if we can help with anything while you are contributing. :-) If you can continue to pick out bugs and fix them, that would be awesome!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'accomplishments/daemon/api.py'
2--- accomplishments/daemon/api.py 2012-08-01 19:48:07 +0000
3+++ accomplishments/daemon/api.py 2012-08-04 00:45:24 +0000
4@@ -1703,9 +1703,9 @@
5 if config.has_section("notifications"):
6 val = config.getboolean('notifications',
7 'show_all_notifications')
8- return val
9+ return not val
10
11- return False
12+ return True
13
14 def _coll_from_accomID(self,accomID):
15 return accomID.split("/")[0]

Subscribers

People subscribed via source and target branches