lp:~blue-shell/blue-shell/baloo

Created by Rohan Garg on 2014-01-08 and last modified on 2019-10-13
Get this branch:
bzr branch lp:~blue-shell/blue-shell/baloo

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Blue-Shell
Project:
blue-shell
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/baloo.

The next import is scheduled to run in 2 hours.

Last successful import was 3 hours ago.

Import started 3 hours ago on izar and finished 3 hours ago taking 15 seconds — see the log
Import started 9 hours ago on izar and finished 9 hours ago taking 15 seconds — see the log
Import started 15 hours ago on alnitak and finished 15 hours ago taking 20 seconds — see the log
Import started 21 hours ago on alnitak and finished 21 hours ago taking 20 seconds — see the log
Import started on 2019-10-16 on izar and finished on 2019-10-16 taking 15 seconds — see the log
Import started on 2019-10-16 on izar and finished on 2019-10-16 taking 20 seconds — see the log
Import started on 2019-10-15 on alnitak and finished on 2019-10-15 taking 20 seconds — see the log
Import started on 2019-10-15 on izar and finished on 2019-10-15 taking 15 seconds — see the log
Import started on 2019-10-15 on izar and finished on 2019-10-15 taking 15 seconds — see the log
Import started on 2019-10-15 on izar and finished on 2019-10-15 taking 20 seconds — see the log

Recent revisions

1614. By Friedrich W. H. Kossebau <email address hidden> on 2019-10-13

Use new INCLUDE_DIRS with ecm_add_qch, to have doxygen see more includes

GIT_SILENT

1613. By Stefan Bruens on 2019-10-12

Use propertymap to store properties in Baloo::Result

Summary:
Storing properties directly in a PropertyMap is more efficient (no
temporary conversion of property number to string, lookup with integer
key), and it also guarantees to have the same data as the extractor used
by BalooWigets, as long as (de)serialization to the Json format stored in
the DB is lossless.

Depends on D19087

Test Plan: ctest

Reviewers: #baloo, #frameworks, ngraham, poboiko, astippich

Reviewed By: #baloo, ngraham, astippich

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D19088

1612. By Stefan Bruens on 2019-10-12

Add standalone conversion functions for PropertyMap to Json and vice versa

Summary:
Baloo caches property data, and uses Json for serializing it. For storing,
it populates a QVariantMap, where multiple values for the same key are
stored as a QVariantList (QJsonObject::fromVariantMap only handles one
value per key). After deserialization, the KFileMetaData::PropertyMap
also contains QVariantLists for keys with multiple values.

To handle multiple property values per key correctly, do the serialization
and deserialization manually. This also save the temporary QVariantMap
on deserialization.

Add unit tests to test roundtrip from PropertyMap to JSon and back. This
is now possible as the serialization code is no longer done inline.

It makes it also easier to keep serialization and deserialization in
sync, as it is no longer in different files (src/file/result.cpp and
src/file/extractor/file.cpp).

Test Plan: ctest

Reviewers: #baloo, #frameworks, ngraham, poboiko, astippich

Reviewed By: #baloo, ngraham, astippich

Subscribers: mgallien, kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D19087

1611. By Albert Astals Cid on 2019-10-12

Add a few const &

Summary: These things aren't super expensive to copy, but const & is less expensive

Reviewers: meven

Reviewed By: meven

Subscribers: meven, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D24584

1610. By l10n daemon script <email address hidden> on 2019-10-12

GIT_SILENT Upgrade KF5 version to 5.64.0.

1609. By Kai Krakow on 2019-10-11

[Database] Rework handling environment flags

Summary: This will keep the code of the following changes simpler to read. It introduces no functional change.

Reviewers: ngraham, #baloo

Reviewed By: ngraham, #baloo

Subscribers: kde-frameworks-devel, ngraham, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D24539

1608. By Stefan Bruens on 2019-10-09

Replace recursion in FilteredDirIterator with loop iteration

Summary:
In case many consecutive files are skipped in a directory, the
recursive next() implementation recursed for every file, i.e.
calling itself repeatedly.

Instead, loop over all directory items until either a file or directory
is found which should be indexed, or there are no more items left.

Move the "shouldIndexHidden" variable out of the loop, as it is
invariant.

Test Plan: ctest -R filtereddiriterator

Reviewers: #baloo, ngraham, astippich

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D24502

1607. By l10n daemon script <email address hidden> on 2019-10-06

GIT_SILENT Upgrade ECM and KF5 version requirements for 5.63.0 release.

1606. By Albert Astals Cid on 2019-10-04

Small performance improvements suggested by clang-tidy

Reviewers: meven

Reviewed By: meven

Subscribers: meven, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D24405

1605. By David Faure on 2019-09-17

GIT_SILENT disable deprecated API from Qt 5.13 and before

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers