lp:~blue-shell/blue-shell/baloo

Created by Rohan Garg on 2014-01-08 and last modified on 2019-04-18
Get this branch:
bzr branch lp:~blue-shell/blue-shell/baloo

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Blue-Shell
Project:
blue-shell
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/baloo.

The next import is scheduled to run in 5 hours.

Last successful import was 36 minutes ago.

Import started 36 minutes ago on izar and finished 36 minutes ago taking 20 seconds — see the log
Import started 6 hours ago on alnitak and finished 6 hours ago taking 20 seconds — see the log
Import started 12 hours ago on alnitak and finished 12 hours ago taking 20 seconds — see the log
Import started 18 hours ago on izar and finished 18 hours ago taking 20 seconds — see the log
Import started on 2019-04-24 on alnitak and finished on 2019-04-24 taking 15 seconds — see the log
Import started on 2019-04-24 on alnitak and finished on 2019-04-24 taking 20 seconds — see the log
Import started on 2019-04-24 on izar and finished on 2019-04-24 taking 20 seconds — see the log
Import started on 2019-04-24 on izar and finished on 2019-04-24 taking 20 seconds — see the log
Import started on 2019-04-23 on alnitak and finished on 2019-04-23 taking 20 seconds — see the log
Import started on 2019-04-23 on izar and finished on 2019-04-23 taking 20 seconds — see the log

Recent revisions

1514. By Stefan Bruens on 2019-04-18

[balooctl] Switch multiline output to new helper

Summary:
Output is mostly unchanged, but symlinks are no longer shown
as "Basic Indexing: Scheduled."

Depends on D20617.

Test Plan: balooctl status <file>

Reviewers: #baloo, #frameworks, ngraham, astippich, poboiko

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D20620

1513. By Stefan Bruens on 2019-04-18

[balooctl] Use new helper in json output

Summary:
The output is mostly the same, save for the following fixes:
- symlinks are no longer listed as "indexing=basic, state=scheduled", but
  are omitted from output
- in case "onlyBasicIndexing" is active, indexing now shows "basic"
  instead of "content"
- excluded files are now "indexing=none, state=disabled" instead of
  "indexing=basic, state=disabled"

Depends on D20617

Test Plan: balooctl status -f json <file>

Reviewers: #baloo, #frameworks, ngraham, astippich, poboiko

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D20619

1512. By Stefan Bruens on 2019-04-18

[balooctl] Use new helper for simple format output

Summary:
Symlinks are no longer reported as "Basic indexing scheduled",
otherwise the output is unchanged.

Depends on D20617.

Test Plan: balooctl status -f simple <file>

Reviewers: #baloo, #frameworks, ngraham, astippich, poboiko

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D20618

1511. By Stefan Bruens on 2019-04-18

[balooctl] Factor out file index status collection from output

Summary:
The three output formats (singleline, multiline, json) each implement
the collection of the file status individually.

Reviewers: #baloo, #frameworks, ngraham, astippich, poboiko

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D20617

1510. By Stefan Bruens on 2019-04-15

Keep empty Json metadata docs out of DocumentData DB

Summary:
In case a document is marked for content indexing, but none of the
extractors returns any data, the Baloo::Result::finish() method will
serialize the data as an empty Json document, "{}".

Having no data for a document in the DB is no error, this is the case
already when content indexing is disabled or when the indexer has not
yet processed the document, so leave it out to save some space.

Reviewers: #baloo, #frameworks, astippich, ngraham, poboiko

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D20556

1509. By Stefan Bruens on 2019-04-14

[balooshow] Allow referencing files by URL from hardlink

In case the provided URL points to a hardlink outside the indexed paths,
but the file is indexed via a different path, show the file information.

1508. By Stefan Bruens on 2019-04-14

[balooshow] Suppress warning when URL refers to unindexed file

The DB document is 0 for unindexed files, but this is not a DB error.
Just show the regular "No index information found" message.

1507. By l10n daemon script <email address hidden> on 2019-04-13

GIT_SILENT Upgrade KF5 version to 5.58.0.

1506. By Stefan Bruens on 2019-04-11

Simplify orPostingIterator and make it faster

Summary:
Trivial searches (e.g. baloosearch foo) are expanded to a large list
of ORed small results sets (e.g. 80 terms with 2...5 entries), thus
speeding it up is quite beneficial.

Currently, iterators which no longer return any entries are deleted
and replaced with nullptrs, thus the value has to be checked on each
iteration. The saved instructions are sufficient to more than amortize
the cost of moving the remaining elements in the vector.

The or operator has to return the smallest ID of the combined sets.
Instead of doing a traversal on each next() call, determine the smallest
ID on the first call and update it when checking if the iterators have
to be advanced.

Keep the docId in a local variable, as the virtual function call to
(PostingIterator*)->docId() is somewhat expensive.

According to valgrind, typical execution cost of Baloo::Query::exec()
is reduced by 25% to 40%.

Signed-off-by: Stefan BrĂ¼ns <email address hidden>

Test Plan: valgrind --tool=callgrind baloosearch foo OR bar

Reviewers: #baloo, #frameworks, poboiko, ngraham

Reviewed By: #baloo, ngraham

Subscribers: ngraham, fvogt, kde-frameworks-devel, #frameworks

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D11828

1505. By Stefan Bruens on 2019-04-11

Ensure QFileInfo is valid for the first FilteredDirIterator entry

Summary:
FilteredDirIterator returns its own path for the first next() call. As
the fileInfo() from the underlying QDirIterator is only valid after
the QDirIterator::next() has been called, the first QFileInfo was the
default constructed one.

Initialize a proper QFileInfo() on m_firstItem, and use the QDirIterators
fileInfo() only for the subsequent ones.

Test Plan: make

Reviewers: #baloo, #frameworks, ngraham, astippich, poboiko

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D20332

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers