lp:~blue-shell/blue-shell/baloo

Created by Rohan Garg on 2014-01-08 and last modified on 2018-12-11
Get this branch:
bzr branch lp:~blue-shell/blue-shell/baloo

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Blue-Shell
Project:
blue-shell
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/baloo.

The next import is scheduled to run in 19 minutes.

Last successful import was 5 hours ago.

Import started 5 hours ago on izar and finished 5 hours ago taking 15 seconds — see the log
Import started 11 hours ago on izar and finished 11 hours ago taking 15 seconds — see the log
Import started 17 hours ago on alnitak and finished 17 hours ago taking 20 seconds — see the log
Import started 23 hours ago on izar and finished 23 hours ago taking 15 seconds — see the log
Import started on 2018-12-10 on alnitak and finished on 2018-12-10 taking 20 seconds — see the log
Import started on 2018-12-10 on alnitak and finished on 2018-12-10 taking 15 seconds — see the log
Import started on 2018-12-10 on izar and finished on 2018-12-10 taking 15 seconds — see the log
Import started on 2018-12-10 on izar and finished on 2018-12-10 taking 15 seconds — see the log
Import started on 2018-12-09 on izar and finished on 2018-12-09 taking 15 seconds — see the log
Import started on 2018-12-09 on alnitak and finished on 2018-12-09 taking 20 seconds — see the log

Recent revisions

1427. By Alexander Stippich <email address hidden> 20 hours ago

add documentation to result class

Reviewers: #baloo, bruns

Reviewed By: #baloo, bruns

Subscribers: yurchor, kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D17301

1426. By l10n daemon script <email address hidden> on 2018-12-09

GIT_SILENT Upgrade KF5 version to 5.54.0.

1425. By Stefan Bruens on 2018-12-04

Move internal helper from BasicIndexingJob to anonymous namespace

Summary:
Also remove the return value, as it not evaluated, and not even useful -
we are not interested in the presence of tags, but if the tags where
modified. The latter can only be determined from the write transaction
(Read-modify-check-write).

Reviewers: #baloo, #frameworks, astippich, ngraham

Reviewed By: astippich

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D17324

1424. By Stefan Bruens on 2018-12-03

Add "image/svg" as Type::Image to the BasicIndexingJob

Reviewers: #baloo, #frameworks, astippich, ngraham

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D17337

1423. By Stefan Bruens on 2018-12-03

Minor optimization and cleanup for PositionCodec

Summary:
Both getVarint32Ptr and getVarint32PtrFallback return nullptr when
p >= limit. Avoid the call to getVarint32PtrFallback and immediately
return from getVarint32.

As it is safe to call getVarint32 with p >= limit, skip the extra check in
each getDifferentialVarInt32 loop iteration, speeds up decoding results
for the 3 benchmark cases by ~10%.

Remove unnecessary reinterpret_cast<char*>(p), p is a char*.

Test Plan:
positioncodecbenchmark
ctest

Reviewers: #baloo, #frameworks, ngraham, astippich, poboiko

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D17332

1422. By Stefan Bruens on 2018-12-03

Avoid potential nullptr access for Document, use reference instead

Summary:
Using a TermGenerator without backing document is pointless and can
even crash when the document has been initialized with a nullptr.

Test Plan: ctest

Reviewers: #baloo, #frameworks, astippich, ngraham

Reviewed By: astippich

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D17315

1421. By Stefan Bruens on 2018-12-03

RFC: Add unit test for splitting of numbers in TermGenerator

Summary:
Numbers are not handled as numbers, but literal strings. This is useful
for e.g. serial numbers ("1234-5678-90"), but less so for "real" numbers.

Integral numeric Properties are not fed through the term generator, so
these are handled correctly.

TODO: Determine expected behaviour for searching, i.e. is it ok do return
a document containing "12" when searching for "-12" and vice versa.

Reviewers: #baloo, #frameworks, ngraham, astippich

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D17284

1420. By Stefan Bruens on 2018-12-02

Use Compact json formatting for storing document metadata

Summary:
Document metadata is stored json encoded in the documentdatadb for fast
retrieval. The default pretty-printed format adds useless whitespace:

$> mdb_dump -p -s documentdatadb -n ~/.local/share/baloo/index
{\0a "26": 3648,\0a "27": 5472,\0a "30": "Canon",\0a
    "31": "Canon EOS 70D",\0a "32": "2017-11-12T17:42:35.000Z",\0a
    "33": 1,\0a "34": 9,\0a
    "35": [\0a 3648,\0a 5472\0a ],\0a
    "37": "2017-11-11T16:54:57.000Z",\0a "38": 50,\0a
    "40": 0.01666666753590107,\0a "41": 3.200000047683716,\0a
    "42": 3.375,\0a "43": 0,\0a "44": 0,\0a "45": 5,\0a
    "46": 800\0a}\0a

Using the Compact encoding reduces the storage size significantly:
{"26":3648,"27":5472,"30":"Canon","31":"Canon EOS 70D",
"32":"2017-11-12T17:42:35.000Z","33":1,"34":9,"35":[3648,5472],
"37":"2017-11-11T16:54:57.000Z","38":50,"40":0.01666666753590107,
"41":3.200000047683716,"42":3.375,"43":0,"44":0,"45":5,"46":800}

Reviewers: #baloo, #frameworks, astippich, ngraham

Reviewed By: #baloo, astippich, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D17313

1419. By Stefan Bruens on 2018-12-02

Remove unused map() getter from Result

Summary:
The m_map is only used internally as a intermediate storage for metadata,
it is never accessed from the outside.

Depends on D17298

Test Plan: make

Reviewers: #baloo, #frameworks, astippich, ngraham

Reviewed By: #baloo, astippich, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D17312

1418. By Alexander Stippich <email address hidden> on 2018-12-02

remove unused docId from result

Summary:
The doc id in result class is never set and
never read, so remove it. The id can be
retrieved from the document itself.

Test Plan: compiles

Reviewers: #baloo, bruns, ngraham

Reviewed By: #baloo, bruns, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D17298

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers