lp:~blue-shell/blue-shell/baloo

Created by Rohan Garg on 2014-01-08 and last modified on 2019-02-15
Get this branch:
bzr branch lp:~blue-shell/blue-shell/baloo

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Blue-Shell
Project:
blue-shell
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/baloo.

The next import is scheduled to run in 41 minutes.

Last successful import was 5 hours ago.

Import started 5 hours ago on izar and finished 5 hours ago taking 15 seconds — see the log
Import started 11 hours ago on izar and finished 11 hours ago taking 15 seconds — see the log
Import started 17 hours ago on alnitak and finished 17 hours ago taking 20 seconds — see the log
Import started 23 hours ago on alnitak and finished 23 hours ago taking 20 seconds — see the log
Import started on 2019-02-14 on izar and finished on 2019-02-14 taking 20 seconds — see the log
Import started on 2019-02-14 on izar and finished on 2019-02-14 taking 15 seconds — see the log
Import started on 2019-02-14 on izar and finished on 2019-02-14 taking 15 seconds — see the log
Import started on 2019-02-14 on izar and finished on 2019-02-14 taking 15 seconds — see the log
Import started on 2019-02-13 on alnitak and finished on 2019-02-13 taking 20 seconds — see the log
Import started on 2019-02-13 on alnitak and finished on 2019-02-13 taking 20 seconds — see the log

Recent revisions

1457. By Eol 9 hours ago

[baloo/KInotify] Notify if folder was moved from unwatched place

Summary:
If a folder was moved from an unwatched place, `KInotify` will receive an `EventMoveTo` event,
which doesn't have an `EventMoveFrom` counterpart, and thus it will emit only `created` signal
for the moved directory, but not its contents.
It also won't install watches for the directory (as it does in `EventCreate`).

Instead use FilteredDirIterator to emit created() signal for all the contents as well, and add inotify watches.

It should also now handle the race condition if a directory was created
and files were moved inside it before an inotify watch for this directory was installed.

Note that it's not really realted to symbolic links, one just has to move a folder from excluded place to included.

BUG: 342224

Test Plan:
Added a test case for `KInotifyTest`, similar to one described in Bug 342224.
It passes now.

Reviewers: #baloo, #frameworks, ngraham, bruns

Reviewed By: #baloo, ngraham, bruns

Subscribers: bruns, ngraham, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18698

1456. By Stefan Bruens on 2019-02-11

Simplify term debug output

Pass a QString instead of char* to QDebug, and make it more similar to
regular QDebug output (`QString("foo")` instead of `"foo (QString)"`).

1455. By Stefan Bruens on 2019-02-11

Handle folders matching substrings of included/excluded folders correctly

Summary:
FileIndexerConfig::shouldFolderBeIndexe(...) calls folderInList to
determine if the config should be included or excluded.

For a config:
[0] include: <HOME>/foo
[1] exclude: <HOME>/foo/bar

the folder "<HOME>/foo/barbaz" would be erroneously excluded, as
folders[1].startsWith(folder) is true, i.e. the exclude entry would be
used, although folders[0] is the correct match (folders are matched back
to front).

This can be avoided by normalizing the config entries to always end
with a trailing slash.

For the config itself this had been handled explicitly, but is no longer
needed.

Depends on D18829

Reviewers: #baloo, #frameworks, poboiko, ngraham

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18830

1454. By Stefan Bruens on 2019-02-11

[balooctl] Normalize include/exclude pathes before using it for the config

Summary:
A directory can be added multiple times to the config by just adding a
trailing slash to it, as the config removes any trailing slashes before
storing it, and the `contains(path)` will not match.

Normalize the path to the same format as used by the config and use it
for both adding and removing it.

While using it for removal is not necessary, it allows to use both
variants and matches the "add" behavior, where both variants have the
same effect.

Reviewers: #baloo, #frameworks, poboiko, ngraham

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18829

1453. By Stefan Bruens on 2019-02-10

Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)

Summary:
There is no need to delete and create a new Private on assignment, it is
sufficient to reassign its members.

File::load(url) resets the url, afterwards he old corresponding property
map is no longer valid, clear it.

Test Plan: ctest

Reviewers: #baloo, #frameworks, ngraham, poboiko

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18877

1452. By Alexander Stippich <email address hidden> on 2019-02-09

Use content to determine mime type

Summary:
Determine the mime type for the
extractors based on the content, not on the file
extension. This avoids feeding files with a wrong
or the same file extension into the wrong extractor.

CCBUG: 403902

Reviewers: ngraham, bruns

Reviewed By: ngraham

Subscribers: kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18819

1451. By l10n daemon script <email address hidden> on 2019-02-09

GIT_SILENT Upgrade KF5 version to 5.56.0.

1450. By Stefan Bruens on 2019-02-08

Get rid of mostly unused filePathToStat overload

Summary:
It is only used in one place to retrieve the device ID, which can also
be retrieved from the fileId.

Reviewers: #baloo, #frameworks, poboiko, ngraham

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18833

1449. By Stefan Bruens on 2019-02-08

[Extractor] Exclude GPG encrypted data from being indexed

Summary:
application/pgp-encrypted may be encoded as base64 and thus inherits from
text/plain, but contains no extractable plaintext at all.

CCBUG: 386791

Reviewers: #baloo, #frameworks, ngraham, poboiko

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18851

1448. By Stefan Bruens on 2019-02-07

[balooctl] Actually abort a malformed command instead of just saying so

Summary:
A single directory entry can either be included or excluded, but never
both. Reject any such attempt.

Reviewers: #baloo, #frameworks, poboiko, ngraham

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18828

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers