Merge lp:~blr/launchpad/dont-fear-the-repr into lp:launchpad

[Kit Randel]

Add a repr for PackageDiffJob and SourcePackageRelease.

Adds a repr for PackageDiffJob in the form:

<PackageDiffJob from {from-sourcepkg-name} (id: {from-id}, version: {from-version}) to {to-sourcepkg-name} (id: {to-id}, version: {to-version}) for {requester}>

and a repr for SourcePackageRelease in the form:
<{name} (id: {id}, version: {version})>

[William Grant (wgrant)]

from_source and to_source are NOT NULL in the DB, so checking for None there isn't really necessary. It might be worth giving SourcePackageRelease a sensible repr rather than manually formatting two of them here.

[Kit Randel (blr)]

> It might be worth giving SourcePackageRelease a
> sensible repr rather than manually formatting two of them here.
Sounds good, I'll look at that, thanks.

[William Grant (wgrant)]

The SourcePackageRelease repr should start with "<SourcePackageRelease", as it currently doesn't indicate which package it is. Might as well also call repr() on the object rather than manually invoking __repr__().

review: Needs Fixing (code)

[Kit Randel (blr)]

Thanks, have tidied that up.

On Fri, Jun 5, 2015 at 9:27 PM, William Grant <email address hidden> wrote:

> Review: Needs Fixing code
>
> The SourcePackageRelease repr should start with "<SourcePackageRelease",
> as it currently doesn't indicate which package it is. Might as well also
> call repr() on the object rather than manually invoking __repr__().
> --
> https://code.launchpad.net/~blr/launchpad/dont-fear-the-repr/+merge/261174
> You are the owner of lp:~blr/launchpad/dont-fear-the-repr.
>

--
Kit Randel (blr)
Canonical - Ubuntu Engineering - Launchpad & Continuous Integration Team

[William Grant (wgrant)]

review: Approve (code)

[Barki Mustapha (mustbarki)]

please i need all help about
commands sudo
and how to be more efficient

Join me on tsū, they are sharing social revenues with all of us
http://mlmmomsndads.com/barki2015 #‎tsunation
https://www.tsu.co/barki2015
#‎workwithbarki #‎love
My Resume <http://sdrv.ms/1g78uwe>:
http://www.fourcornersalliancegroup.com/?a=barkimustapha
  https://skydrive.live.com/redir?resid=2DFE3F29565FB012%21273
1) BARKI MUSTAPHA
2) 3 Lot Redouane 20800 Mohammedia Morocco
3) [phone]
4) Paypal : <email address hidden>
5) BMCE BANK
6) Agence BMCE Mohammedia Boulvard Palestine N 3031 Lotissement Redouane
7) 7870011200000022732
8) 011787000011200000022732/ BMCE MAMC
9) Engineer Marine 19/01/1976 Maried
10) Card id A766807
Engineer Automation http://www.fourcornersalliancegroup.com/?a=barkimustapha
SEA CAPTAIN
https://drive.google.com/file/d/0B-KpjpI-05IlcklPZmtOb2ZqZ2c/edit?usp=sharing
skype : barki.mustapha2
As engineer Marine GSE, I can bring my knowledge and expertise in
automation, servo, mechanical, hydraulic, traditional security, management
and HR / equipment,.

Responsive and very adaptable, I am convinced that a company like yours
will appreciate my motivation and drive that inspires me. Your goals become
mine and I know how to invest in your projects
YOU ask rigor, methodology and professionalism and personal attention at
all times. My internship allowed me to have a good view of this environment
and put into practice my knowledge. Rewarding, they convinced me of my
desire to get involved further on behalf of a company that will offer me a
position of responsibility.
I stand at your disposal and I think that an interview will allow me to
convince you of my serious.
B.M #mastercard <https://www.facebook.com/hashtag/mastercard> #free
<https://www.facebook.com/hashtag/free> #income
<https://www.facebook.com/hashtag/income> #program
<https://www.facebook.com/hashtag/program> join me for free http://
share.payoneer-affiliates.com/a/clk/1yW6bg #payoneer
<http://share.payoneer-affiliates.com/a/clk/1yW6bg#payoneer> #mastercard
<https://www.facebook.com/hashtag/mastercard> #free
<https://www.facebook.com/hashtag/free> #income
<https://www.facebook.com/hashtag/income> #program
<https://www.facebook.com/hashtag/program>
#success <https://www.facebook.com/hashtag/success> #instagood
<https://www.facebook.com/hashtag/instagood> #photooftheday
<https://www.facebook.com/hashtag/photooftheday> #picoftheday
<https://www.facebook.com/hashtag/picoftheday> #bestoftheday
<https://www.facebook.com/hashtag/bestoftheday> #instadaily
<https://www.facebook.com/hashtag/instadaily> #igdaily
<https://www.facebook.com/hashtag/igdaily> #follow
<https://www.facebook.com/hashtag/follow> #entrepreneur
<https://www.facebook.com/hashtag/entrepreneur> #money
<https://www.facebook.com/hashtag/money> #networkmarketing
<https://www.facebook.com/hashtag/networkmarketing> #mlm
<https://www.facebook.com/hashtag/mlm> #worldventures
<https://www.facebook.com/hashtag/worldventures> #motivation
<https://www.facebook.com/hashtag/motivation> #quotes
<https://www.facebook.com/hashtag/quotes>

2015-06-05 23:32 GMT+01:00 William Grant <email address hidden>:

> Review: Approve code
>
>
> --
> htt...

[Barki Mustapha (mustbarki)]

shot down system thirth party
new config
about error
is sudo apt-get install-f
unknow for mine

Join me on tsū, they are sharing social revenues with all of us
http://mlmmomsndads.com/barki2015 #‎tsunation
https://www.tsu.co/barki2015
#‎workwithbarki #‎love
My Resume <http://sdrv.ms/1g78uwe>:
http://www.fourcornersalliancegroup.com/?a=barkimustapha
  https://skydrive.live.com/redir?resid=2DFE3F29565FB012%21273
1) BARKI MUSTAPHA
2) 3 Lot Redouane 20800 Mohammedia Morocco
3) [phone]
4) Paypal : <email address hidden>
5) BMCE BANK
6) Agence BMCE Mohammedia Boulvard Palestine N 3031 Lotissement Redouane
7) 7870011200000022732
8) 011787000011200000022732/ BMCE MAMC
9) Engineer Marine 19/01/1976 Maried
10) Card id A766807
Engineer Automation http://www.fourcornersalliancegroup.com/?a=barkimustapha
SEA CAPTAIN
https://drive.google.com/file/d/0B-KpjpI-05IlcklPZmtOb2ZqZ2c/edit?usp=sharing
skype : barki.mustapha2
As engineer Marine GSE, I can bring my knowledge and expertise in
automation, servo, mechanical, hydraulic, traditional security, management
and HR / equipment,.

Responsive and very adaptable, I am convinced that a company like yours
will appreciate my motivation and drive that inspires me. Your goals become
mine and I know how to invest in your projects
YOU ask rigor, methodology and professionalism and personal attention at
all times. My internship allowed me to have a good view of this environment
and put into practice my knowledge. Rewarding, they convinced me of my
desire to get involved further on behalf of a company that will offer me a
position of responsibility.
I stand at your disposal and I think that an interview will allow me to
convince you of my serious.
B.M #mastercard <https://www.facebook.com/hashtag/mastercard> #free
<https://www.facebook.com/hashtag/free> #income
<https://www.facebook.com/hashtag/income> #program
<https://www.facebook.com/hashtag/program> join me for free http://
share.payoneer-affiliates.com/a/clk/1yW6bg #payoneer
<http://share.payoneer-affiliates.com/a/clk/1yW6bg#payoneer> #mastercard
<https://www.facebook.com/hashtag/mastercard> #free
<https://www.facebook.com/hashtag/free> #income
<https://www.facebook.com/hashtag/income> #program
<https://www.facebook.com/hashtag/program>
#success <https://www.facebook.com/hashtag/success> #instagood
<https://www.facebook.com/hashtag/instagood> #photooftheday
<https://www.facebook.com/hashtag/photooftheday> #picoftheday
<https://www.facebook.com/hashtag/picoftheday> #bestoftheday
<https://www.facebook.com/hashtag/bestoftheday> #instadaily
<https://www.facebook.com/hashtag/instadaily> #igdaily
<https://www.facebook.com/hashtag/igdaily> #follow
<https://www.facebook.com/hashtag/follow> #entrepreneur
<https://www.facebook.com/hashtag/entrepreneur> #money
<https://www.facebook.com/hashtag/money> #networkmarketing
<https://www.facebook.com/hashtag/networkmarketing> #mlm
<https://www.facebook.com/hashtag/mlm> #worldventures
<https://www.facebook.com/hashtag/worldventures> #motivation
<https://www.facebook.com/hashtag/motivation> #quotes
<https://www.facebook.com/hashtag/quotes>

2015-06-06 1:42 GMT+01:00 Barki Mustapha <email address hidden>:

> please i need...

=== modified file 'lib/lp/soyuz/model/packagediffjob.py'
--- lib/lp/soyuz/model/packagediffjob.py	2013-07-24 10:48:00 +0000
+++ lib/lp/soyuz/model/packagediffjob.py	2015-06-05 21:27:05 +0000
@@ -66,6 +66,19 @@
     implements(IPackageDiffJob)
     classProvides(IPackageDiffJobSource)
 
+    def __repr__(self):
+        """Returns an informative representation of a PackageDiff job."""
+        diff = self.packagediff
+        parts = ['{cls} from {from_spr} to {to_spr}'.format(
+            cls=self.__class__.__name__,
+            from_spr=repr(diff.from_source),
+            to_spr=repr(diff.to_source))
+            ]
+        if diff.requester is not None:
+            parts.append(' for {requester}'.format(
+                requester=diff.requester.name))
+        return '<{repr}>'.format(repr=''.join(parts))
+
     @property
     def packagediff_id(self):
         return simplejson.loads(self.base_json_data)['packagediff']

=== modified file 'lib/lp/soyuz/model/sourcepackagerelease.py'
--- lib/lp/soyuz/model/sourcepackagerelease.py	2015-02-11 14:43:44 +0000
+++ lib/lp/soyuz/model/sourcepackagerelease.py	2015-06-05 21:27:05 +0000
@@ -143,6 +143,12 @@
         super(SourcePackageRelease, self).__init__(*args, **kwargs)
         self.copyright = copyright
 
+    def __repr__(self):
+        """Returns an informative representation of a SourcePackageRelease."""
+        return '<{cls} {pkg_name} (id: {id}, version: {version})>'.format(
+            cls=self.__class__.__name__, pkg_name=self.name,
+            id=self.id, version=self.version)
+
     @property
     def copyright(self):
         """See `ISourcePackageRelease`."""

=== modified file 'lib/lp/soyuz/tests/test_packagediffjob.py'
--- lib/lp/soyuz/tests/test_packagediffjob.py	2013-08-07 06:26:36 +0000
+++ lib/lp/soyuz/tests/test_packagediffjob.py	2015-06-05 21:27:05 +0000
@@ -64,6 +64,15 @@
         jobs = list(PackageDiffJob.iterReady())
         self.assertEqual(1, len(jobs))
 
+    def test___repr__(self):
+        _, job = self.makeJob()
+        expected_repr = ('<PackageDiffJob from {from_spr}'
+                         ' to {to_spr} for {user}>').format(
+                             from_spr=repr(job.packagediff.from_source),
+                             to_spr=repr(job.packagediff.to_source),
+                             user=job.packagediff.requester.name)
+        self.assertEqual(expected_repr, repr(job))
+
     def test_run(self):
         diff, job = self.makeJob()
         method = FakeMethod()

=== modified file 'lib/lp/soyuz/tests/test_sourcepackagerelease.py'
--- lib/lp/soyuz/tests/test_sourcepackagerelease.py	2014-10-31 10:34:51 +0000
+++ lib/lp/soyuz/tests/test_sourcepackagerelease.py	2015-06-05 21:27:05 +0000
@@ -25,6 +25,14 @@
         spr = self.factory.makeSourcePackageRelease()
         self.assertIs(None, spr.uploader)
 
+    def test___repr__(self):
+        spr = self.factory.makeSourcePackageRelease()
+        expected_repr = ('<{cls} {pkg_name} (id: {id}, '
+                         'version: {version})>').format(
+                             cls=spr.__class__.__name__, pkg_name=spr.name,
+                             id=spr.id, version=spr.version)
+        self.assertEqual(expected_repr, repr(spr))
+
     def test_uploader_dsc_package(self):
         owner = self.factory.makePerson()
         key = self.factory.makeGPGKey(owner)