Merge lp:~blr/charms/trusty/gunicorn/pid-file into lp:charms/trusty/gunicorn

Proposed by Kit Randel
Status: Merged
Approved by: Michael Nelson
Approved revision: 35
Merged at revision: 35
Proposed branch: lp:~blr/charms/trusty/gunicorn/pid-file
Merge into: lp:charms/trusty/gunicorn
Diff against target: 46 lines (+7/-0)
3 files modified
config.yaml (+4/-0)
hooks/tests/test_template.py (+2/-0)
templates/upstart.tmpl (+1/-0)
To merge this branch: bzr merge lp:~blr/charms/trusty/gunicorn/pid-file
Reviewer Review Type Date Requested Status
Michael Nelson (community) Approve
charmers Pending
Review via email: mp+284236@code.launchpad.net

Commit message

Add configuration key for gunicorn's --pid option.

Description of the change

This branch adds a new config key, `pid_file` which defaults to `/tmp/gunicorn.pid`, providing support for gunicorn's --pid option.

To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-02-27 10:20:51 +0000
3+++ config.yaml 2016-01-28 09:57:47 +0000
4@@ -75,6 +75,10 @@
5 type: string
6 default: "0.0.0.0"
7 description: "IP adresses that Gunicorn will listen on. By default we listen on all of them."
8+ pid_file:
9+ type: string
10+ default: /tmp/gunicorn.pid
11+ description: "Background PID file."
12 port:
13 type: int
14 default: 8080
15
16=== modified file 'hooks/tests/test_template.py'
17--- hooks/tests/test_template.py 2014-02-27 14:54:18 +0000
18+++ hooks/tests/test_template.py 2016-01-28 09:57:47 +0000
19@@ -42,6 +42,7 @@
20 --bind=LISTEN_IP:PORT \\
21 --log-file=WSGI_LOG_FILE \\
22 --log-level=WSGI_LOG_LEVEL \\
23+ --pid=PID_FILE \\
24 --access-logfile=WSGI_ACCESS_LOGFILE \\
25 --access-logformat=WSGI_ACCESS_LOGFORMAT \\
26 WSGI_EXTRA \\
27@@ -86,6 +87,7 @@
28 'wsgi_umask',
29 'wsgi_log_file',
30 'wsgi_log_level',
31+ 'pid_file',
32 'wsgi_access_logfile',
33 'wsgi_access_logformat',
34 'listen_ip',
35
36=== modified file 'templates/upstart.tmpl'
37--- templates/upstart.tmpl 2014-02-27 14:54:18 +0000
38+++ templates/upstart.tmpl 2016-01-28 09:57:47 +0000
39@@ -35,6 +35,7 @@
40 --bind={{ listen_ip }}:{{ port }} \
41 --log-file={{ wsgi_log_file }} \
42 --log-level={{ wsgi_log_level }} \
43+ --pid={{ pid_file }} \
44 {%- if wsgi_access_logfile %}
45 --access-logfile={{ wsgi_access_logfile }} \
46 {%- endif %}

Subscribers

People subscribed via source and target branches