Merge lp:~bloodearnest/u1-test-utils/optional-captcha into lp:u1-test-utils

Proposed by Simon Davy
Status: Merged
Approved by: Leo Arias
Approved revision: 61
Merged at revision: 61
Proposed branch: lp:~bloodearnest/u1-test-utils/optional-captcha
Merge into: lp:u1-test-utils
Diff against target: 17 lines (+4/-3)
1 file modified
u1testutils/sso/sst/pages.py (+4/-3)
To merge this branch: bzr merge lp:~bloodearnest/u1-test-utils/optional-captcha
Reviewer Review Type Date Requested Status
Leo Arias (community) code review Approve
Review via email: mp+161834@code.launchpad.net

Commit message

handle optional captcha

Description of the change

handle optional captcha

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

Sorry, I'm on holidays so I was sleeping :)
You don't really need my approval for u1-test-utils branch. Any one from as or qa would be a good reviewer.
+1

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'u1testutils/sso/sst/pages.py'
2--- u1testutils/sso/sst/pages.py 2013-04-24 04:22:28 +0000
3+++ u1testutils/sso/sst/pages.py 2013-05-01 14:58:25 +0000
4@@ -155,9 +155,10 @@
5 sst.actions.write_textfield('id_password', user.password)
6 sst.actions.write_textfield(
7 'id_passwordconfirm', password_confirmation)
8- # Even though the recaptcha field is ignored for our tests, we do
9- # want to verify that it is on the page.
10- sst.actions.write_textfield('recaptcha_response_field', 'ignored')
11+
12+ captcha_field = 'recaptcha_response_field'
13+ if sst.actions.exists_element(id=captcha_field):
14+ sst.actions.write_textfield(captcha_field, 'ignored')
15
16 def _click_continue(self):
17 continue_button = sst.actions.get_element(name='continue')

Subscribers

People subscribed via source and target branches

to all changes: