Merge lp:~bloodearnest/canonical-identity-provider/ssoclient-502 into lp:~canonical-isd-hackers/canonical-identity-provider/ssoclient

Proposed by Simon Davy
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 9
Merged at revision: 7
Proposed branch: lp:~bloodearnest/canonical-identity-provider/ssoclient-502
Merge into: lp:~canonical-isd-hackers/canonical-identity-provider/ssoclient
Diff against target: 24 lines (+2/-2)
2 files modified
ssoclient/tests/test_v2.py (+1/-1)
ssoclient/v2/errors.py (+1/-1)
To merge this branch: bzr merge lp:~bloodearnest/canonical-identity-provider/ssoclient-502
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+165596@code.launchpad.net

Commit message

Change CAPTCHA_ERROR code from 504 to 502

Description of the change

Change CAPTCHA_ERROR code from 504 to 502

To post a comment you must log in.
Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ssoclient/tests/test_v2.py'
2--- ssoclient/tests/test_v2.py 2013-05-22 17:23:24 +0000
3+++ ssoclient/tests/test_v2.py 2013-05-24 12:29:29 +0000
4@@ -128,7 +128,7 @@
5 with self.assertRaises(errors.CaptchaFailure):
6 self.client.register(email='blah')
7
8- @patch(REQUEST, return_value=mock_response(504, code="CAPTCHA_ERROR"))
9+ @patch(REQUEST, return_value=mock_response(502, code="CAPTCHA_ERROR"))
10 def test_register_captcha_error(self, mock_request):
11 with self.assertRaises(errors.CaptchaError):
12 self.client.register(email='blah')
13
14=== modified file 'ssoclient/v2/errors.py'
15--- ssoclient/v2/errors.py 2013-05-22 16:52:20 +0000
16+++ ssoclient/v2/errors.py 2013-05-24 12:29:29 +0000
17@@ -58,6 +58,6 @@
18 error_code = "ALREADY_REGISTERED"
19
20
21-# 504
22+# 502
23 class CaptchaError(ApiException):
24 error_code = "CAPTCHA_ERROR"

Subscribers

People subscribed via source and target branches