Code review comment for lp:~blamar/nova/openstack-api-1-1-images

On Thu, Mar 24, 2011 at 11:48 AM, Brian Lamar <email address hidden> wrote:
>> If you run your tests with ./run_tests.sh -V
>
> My results from ./run_tests.sh -V show:
>
> Ran 532 tests in 394.149s
>
> OK
>
> and no pep8 failures.

Heh, well, I must be out of my mind, then :) I ran your branch locally
and got this, totally non-related to this patch, error:

nova/tests/test_volume.py:359:63: E202 whitespace before ')'
                                    "--tid=%(tid)d" % locals()
                                                              ^
    Avoid extraneous whitespace in the following situations:

    - Immediately inside parentheses, brackets or braces.

    - Immediately before a comma, semicolon, or colon.

    Okay: spam(ham[1], {eggs: 2})
    E201: spam( ham[1], {eggs: 2})
    E201: spam(ham[ 1], {eggs: 2})
    E201: spam(ham[1], { eggs: 2})
    E202: spam(ham[1], {eggs: 2} )
    E202: spam(ham[1 ], {eggs: 2})
    E202: spam(ham[1], {eggs: 2 })

    E203: if x == 4: print x, y; x, y = y , x
    E203: if x == 4: print x, y ; x, y = y, x
    E203: if x == 4 : print x, y; x, y = y, x
jpipes@serialcoder:~/repos/nova/openstack-api-1-1-images$

It would *seem* that your code in /nova/api/openstack/images.py would
trigger the same error, but it doesn't! :)

-jay