Code review comment for lp:~blamar/nova/openstack-api-1-1-images

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Looking good! What would you think about changing the generate_href method from:
    "%s/images/%s" % (self._url, image_id)
to:
    os.path.join(self._url, "images", image_id)

« Back to merge proposal