Merge lp:~blake-rouse/postgresfixture/fix-1734769 into lp:postgresfixture

Proposed by Blake Rouse
Status: Merged
Approved by: Gavin Panella
Approved revision: 16
Merged at revision: 15
Proposed branch: lp:~blake-rouse/postgresfixture/fix-1734769
Merge into: lp:postgresfixture
Diff against target: 21 lines (+2/-2)
1 file modified
setup.py (+2/-2)
To merge this branch: bzr merge lp:~blake-rouse/postgresfixture/fix-1734769
Reviewer Review Type Date Requested Status
Gavin Panella Approve
Review via email: mp+334333@code.launchpad.net

Commit message

Fixes LP: 1734769 - Fix install_require and tests_require to use a list and a tuple instead of a set.

To post a comment you must log in.
16. By Blake Rouse

Fix install_requires as well.

Revision history for this message
Gavin Panella (allenap) wrote :

Looks good. (Damned setuptools).

review: Approve
Revision history for this message
Gavin Panella (allenap) wrote :

I also learned that tests don't pass (for me, at least) with the system python3-psycopg2 package installed. Mmm, virtualenv not really working there.

Revision history for this message
Gavin Panella (allenap) wrote :

Uploaded to PyPI too: https://pypi.python.org/pypi/postgresfixture/0.4.1

Let me know if there are any problems.

Revision history for this message
Blake Rouse (blake-rouse) wrote :

Thanks for the quick merge and push!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2017-01-20 08:02:20 +0000
3+++ setup.py 2017-11-27 21:38:01 +0000
4@@ -17,7 +17,7 @@
5
6
7 with codecs.open("requirements.txt", "rb", encoding="utf-8") as fd:
8- requirements = {line.strip() for line in fd}
9+ requirements = [line.strip() for line in fd]
10
11
12 setup(
13@@ -35,7 +35,7 @@
14 packages={'postgresfixture'},
15 package_dir={'postgresfixture': 'postgresfixture'},
16 install_requires=requirements,
17- tests_require={"testtools >= 0.9.14"},
18+ tests_require=("testtools >= 0.9.14",),
19 test_suite="postgresfixture.tests",
20 include_package_data=True,
21 zip_safe=False,

Subscribers

People subscribed via source and target branches

to all changes: