Merge lp:~blake-rouse/maas/tgt-service-sudoers into lp:~maas-maintainers/maas/packaging

Proposed by Blake Rouse
Status: Merged
Approved by: Blake Rouse
Approved revision: no longer in the source branch.
Merged at revision: 393
Proposed branch: lp:~blake-rouse/maas/tgt-service-sudoers
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 11 lines (+2/-0)
1 file modified
debian/extras/99-maas-sudoers (+2/-0)
To merge this branch: bzr merge lp:~blake-rouse/maas/tgt-service-sudoers
Reviewer Review Type Date Requested Status
Raphaël Badin (community) Approve
Mike Pontillo (community) Approve
Review via email: mp+259437@code.launchpad.net

Commit message

Add "service tgt status" and "service tgt start" to the sudoers file.

This is done so the service monitor can check the status of 'tgt' and start the service when it is down.

Description of the change

This is needed for this final change in the series of changes.

https://code.launchpad.net/~blake-rouse/maas/service-monitor-service/+merge/259435

To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Looks good.

One question: this seems to be upstart specific. On systemd, there is no /usr/sbin/service. So how does this work on systemd?

Most newer scripts I've seen are using 'invoke-rc.d' instead, which is available on both.

review: Approve
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Works on systemd as well. service works for both systemd and upstart. That
is why I chose to use it.
On May 18, 2015 6:33 PM, "Mike Pontillo" <email address hidden>
wrote:

> Review: Approve
>
> Looks good.
>
> One question: this seems to be upstart specific. On systemd, there is no
> /usr/sbin/service. So how does this work on systemd?
>
> Most newer scripts I've seen are using 'invoke-rc.d' instead, which is
> available on both.
> --
>
> https://code.launchpad.net/~blake-rouse/maas/tgt-service-sudoers/+merge/259437
> You are the owner of lp:~blake-rouse/maas/tgt-service-sudoers.
>

Revision history for this message
Mike Pontillo (mpontillo) wrote :

Ah, I see. It's in sysvinit-utils.

Revision history for this message
Raphaël Badin (rvb) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/extras/99-maas-sudoers'
2--- debian/extras/99-maas-sudoers 2015-03-25 16:35:38 +0000
3+++ debian/extras/99-maas-sudoers 2015-05-18 20:34:19 +0000
4@@ -2,5 +2,7 @@
5 maas ALL= NOPASSWD: /usr/sbin/service maas-dhcpd6 restart
6 maas ALL= NOPASSWD: /usr/sbin/service maas-dhcpd stop
7 maas ALL= NOPASSWD: /usr/sbin/service maas-dhcpd6 stop
8+maas ALL= NOPASSWD: /usr/sbin/service tgt status
9+maas ALL= NOPASSWD: /usr/sbin/service tgt start
10 maas ALL= NOPASSWD: /usr/sbin/maas-provision
11 maas ALL= NOPASSWD: SETENV: /usr/sbin/tgt-admin, /usr/bin/uec2roottar

Subscribers

People subscribed via source and target branches