Code review comment for lp:~blake-rouse/maas/osystem-preseed-prefix

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Nice branch! Small, focused and easy to follow :) It's good to land with a couple of nits to fix as below:

[1]

174 -{{ preseed }}
175 +{{ preseed|force_escape }}

Was there a reason to use force_escape here? Django's docs say to use just "escape" unless you want immediate escaping, which I don't think is the case?

https://docs.djangoproject.com/en/dev/ref/templates/builtins/#std:templatefilter-escape

[2]

The tests for escaping could be improved if they did a more explicit test, such as looking for &lt;mytag&gt; when the preseed is <mytag>.

review: Approve

« Back to merge proposal