MAAS

Merge lp:~blake-rouse/maas/fix-1562939 into lp:~maas-committers/maas/trunk

  1. fix-1562939
  2. Merge into trunk
Proposed by Blake Rouse
Status: Merged
Approved by: Blake Rouse
Approved revision: no longer in the source branch.
Merged at revision: 4847
Proposed branch: lp:~blake-rouse/maas/fix-1562939
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
src/maasserver/migrations/builtin/maasserver/0047_fix_spelling_of_degraded.py (+1/-1)
To merge this branch: bzr merge lp:~blake-rouse/maas/fix-1562939
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+290221@code.launchpad.net

Commit message

Fix update_fields to send a list instead of a string in migration 0047.

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Lgtm!!!!

Revision history for this message
MAAS Lander (maas-lander) wrote :

Voting does not meet specified criteria. Required: Approve >= 1, Disapprove == 0. Got: 1 Pending.

Revision history for this message
Blake Rouse (blake-rouse) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/migrations/builtin/maasserver/0047_fix_spelling_of_degraded.py'
2--- src/maasserver/migrations/builtin/maasserver/0047_fix_spelling_of_degraded.py 2016-03-25 13:21:56 +0000
3+++ src/maasserver/migrations/builtin/maasserver/0047_fix_spelling_of_degraded.py 2016-03-28 16:32:28 +0000
4@@ -11,7 +11,7 @@
5 Service = apps.get_model("maasserver", "Service")
6 for service in Service.objects.filter(status="degraged"):
7 service.status = "degraded";
8- service.save(update_fields="status")
9+ service.save(update_fields=["status"])
10
11
12 class Migration(migrations.Migration):