Code review comment for lp:~blake-rouse/maas/fix-1559398
Revision history for this message
| Blake Rouse (blake-rouse) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Good idea. Moved the imports to each sub command so that they run faster.
Also the clean is called specifically from systemd when the the service before it is started. So its 100% not running when that is called. This ensures that its not being modified at the same time, as its not even running.
The test includes hostname in the lease entry that my previous regex was matching. This regex is specific to a host block not any host in the lease section.