Merge lp:~blake-rouse/maas/fix-1499428 into lp:~maas-committers/maas/trunk

Proposed by Blake Rouse
Status: Merged
Approved by: Blake Rouse
Approved revision: no longer in the source branch.
Merged at revision: 4307
Proposed branch: lp:~blake-rouse/maas/fix-1499428
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 53 lines (+7/-0)
3 files modified
src/maasserver/api/networks.py (+3/-0)
src/maasserver/api/tests/test_network.py (+2/-0)
src/maasserver/api/tests/test_networks.py (+2/-0)
To merge this branch: bzr merge lp:~blake-rouse/maas/fix-1499428
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Approve
Review via email: mp+272305@code.launchpad.net

Commit message

Fix missing resource_uri on the networks endpoint.

To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Ship it!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/api/networks.py'
2--- src/maasserver/api/networks.py 2015-09-09 21:06:11 +0000
3+++ src/maasserver/api/networks.py 2015-09-24 19:14:13 +0000
4@@ -19,6 +19,7 @@
5
6 import re
7
8+from django.core.urlresolvers import reverse
9 from django.shortcuts import get_object_or_404
10 from maasserver.api.support import (
11 admin_method,
12@@ -60,6 +61,8 @@
13 "description": subnet.name,
14 "default_gateway": subnet.gateway_ip,
15 "dns_servers": subnet.dns_servers,
16+ "resource_uri": reverse(
17+ 'network_handler', args=["subnet-%d" % subnet.id]),
18 }
19
20
21
22=== modified file 'src/maasserver/api/tests/test_network.py'
23--- src/maasserver/api/tests/test_network.py 2015-09-09 21:06:11 +0000
24+++ src/maasserver/api/tests/test_network.py 2015-09-24 19:14:13 +0000
25@@ -64,6 +64,7 @@
26 subnet.name,
27 subnet.gateway_ip,
28 subnet.dns_servers,
29+ reverse('network_handler', args=["subnet-%d" % subnet.id]),
30 ),
31 (
32 parsed_result['name'],
33@@ -73,6 +74,7 @@
34 parsed_result['description'],
35 parsed_result['default_gateway'],
36 parsed_result['dns_servers'],
37+ parsed_result['resource_uri'],
38 ))
39
40 def test_GET_returns_404_for_unknown_network(self):
41
42=== modified file 'src/maasserver/api/tests/test_networks.py'
43--- src/maasserver/api/tests/test_networks.py 2015-09-09 21:06:11 +0000
44+++ src/maasserver/api/tests/test_networks.py 2015-09-24 19:14:13 +0000
45@@ -81,6 +81,8 @@
46 "description": subnet.name,
47 "default_gateway": subnet.gateway_ip,
48 "dns_servers": subnet.dns_servers,
49+ "resource_uri": reverse(
50+ 'network_handler', args=["subnet-%d" % subnet.id]),
51 }, returned_subnet)
52
53 def test_GET_returns_empty_if_no_subnets(self):