Merge lp:~blake-rouse/maas/fix-1401349-1.7 into lp:maas/1.7

Proposed by Blake Rouse
Status: Merged
Approved by: Blake Rouse
Approved revision: no longer in the source branch.
Merged at revision: 3319
Proposed branch: lp:~blake-rouse/maas/fix-1401349-1.7
Merge into: lp:maas/1.7
Diff against target: 24 lines (+2/-2)
2 files modified
src/maasserver/templates/maasserver/node_view.html (+1/-1)
src/maasserver/views/tests/test_nodes.py (+1/-1)
To merge this branch: bzr merge lp:~blake-rouse/maas/fix-1401349-1.7
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+244451@code.launchpad.net

Commit message

Fix node_view to use display_memory and adjust units to GiB.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Self-approving backport.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/templates/maasserver/node_view.html'
2--- src/maasserver/templates/maasserver/node_view.html 2014-12-10 16:29:13 +0000
3+++ src/maasserver/templates/maasserver/node_view.html 2014-12-11 14:59:00 +0000
4@@ -139,7 +139,7 @@
5 <li class="block size3">
6 <h4>Memory</h4>
7 <span>
8- <span data-field="memory">{{ node.memory }}</span> MB
9+ <span data-field="memory">{{ node.display_memory }}</span> GiB
10 </span>
11 </li>
12 <li class="block size3 first">
13
14=== modified file 'src/maasserver/views/tests/test_nodes.py'
15--- src/maasserver/views/tests/test_nodes.py 2014-12-10 18:04:44 +0000
16+++ src/maasserver/views/tests/test_nodes.py 2014-12-11 14:59:00 +0000
17@@ -567,7 +567,7 @@
18 self.assertIn(node.hostname, content_text)
19 self.assertIn(node.display_status(), content_text)
20 self.assertIn(node.architecture, content_text)
21- self.assertIn('%d MB' % (node.memory,), content_text)
22+ self.assertIn('%s GiB' % (node.display_memory(),), content_text)
23 self.assertIn('%d' % (node.cpu_count,), content_text)
24 self.assertIn(self.logged_in_user.username, content_text)
25

Subscribers

People subscribed via source and target branches

to all changes: