Code review comment for lp:~blake-rouse/maas/add-osystem-to-node-form-api

Revision history for this message
Raphaƫl Badin (rvb) wrote :

> Its the same implementation that was there for distro_series.
> If there was no issue the way it was before, why is there now?

The `distro_series` stuff was implemented when the possible choices where not the dynamic object it is now. One could argue that even at that time it was a mistake but the point is that we shouldn't persist doing things the way `distro_series` was implemented for the many reasons stated above. This means that, ideally, we should also perform the validation for `distro_series` at the form level.

« Back to merge proposal