Code review comment for lp:~blake-rouse/maas/add-osystem-to-node-form-api

Revision history for this message
Blake Rouse (blake-rouse) wrote :

osystem has validation in the model, as this field can also be set with the start API call. distro_series always had validation using the choices=, but now its just using a function to perform the validation. It gives the same result.

factory.make_node does not break tests, as the osystem field just like the distro_series field was can be blank. If the field is blank then the default is used, so no tests break.

« Back to merge proposal