Merge ~bladernr/plainbox-provider-resource:1757143-module_resource_change into plainbox-provider-resource:master

[Jeff Lane ]

This changes the module resource to be run as root.

On 4.13 and before, the /proc/modules file returned a memory offset of 0x00000000000 when the file was read by non-root users.

As of 4.15, however, this has changed and reading /proc/modules as a non-root user returns a null reference for each memory offset. This new behaviour causes the module_resource script to traceback (see linked bug).

I have tested this on both 4.15 (bionic) and 4.13 (xenial) and the behaviour is the same in both cases, and the script can be safely run as root in both cases.

[Sylvain Pineau (sylvain-pineau)]

+1 thanks Jeff

review: Approve

diff --git a/jobs/resource.pxu b/jobs/resource.pxu
index 790f2e8..dbcfd1f 100644
--- a/jobs/resource.pxu
+++ b/jobs/resource.pxu
@@ -102,6 +102,7 @@ _summary: Collect information about system memory (/proc/meminfo)
 id: module
 estimated_duration: 0.13
 plugin: resource
+user: root
 command: module_resource
 _description: Generates resources info on running kernel modules
 _summary: Collect information about kernel modules